Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_verify
-
Labels:
-
Story Points:6
-
Epic Link:
-
Sprint:AP S18-4, AP S18-5
-
Team:Alert Production
Description
Currently, ap_verify's ingestion is specific to DECam (in particular, hardcoded references to obs_decam and its tasks' configs). The code should be generalized to use whichever obs package is specified by the input Datasest, preferably without any special-case handling.
Attachments
Issue Links
- blocks
-
DM-13849 Convert all ap_verify test data to obs_test
- Done
- has to be done before
-
- Done
- is blocked by
-
- Done
- is duplicated by
-
DM-12662 ap_pipe should consistently use new-style repos
- Invalid
- relates to
-
- Done
Activity
Hi Meredith Rawls, would you be willing to review this rewrite of ingestion? It involves making some changes to the dataset framework and adding an override file to obs_decam to make everything instrument-independentish.
I have not tried testing on datasets other than DECam, given DM-12315 and the lack of non-DECam datasets. Note that obs_test does not require a config override, and we can worry about the other obs packages once we have datasets for them.
Krzysztof Findeisen
added a comment - Hi Meredith Rawls , would you be willing to review this rewrite of ingestion? It involves making some changes to the dataset framework and adding an override file to obs_decam to make everything instrument-independentish.
I have not tried testing on datasets other than DECam, given DM-12315 and the lack of non-DECam datasets. Note that obs_test does not require a config override, and we can worry about the other obs packages once we have datasets for them. 
As part of this rewrite, refcat "ingestion" should be moved out of _doIngest. Refcats are similar to templates in that they're "pre-ingested", and should be handled similarly.