Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13539

astshim fails to preserve SIP terms for some TAN SIP when writing FITS metadata

    Details

    • Story Points:
      0.5
    • Sprint:
      AP S18-3
    • Team:
      Alert Production

      Description

      Lauren MacArthur has found some cases where a TAN-SIP SkyWcs is not written as TAN-SIP to FITS metadata (instead a local TAN approximation is used). The attached file is a program showing an example. I have reported the issue to David Berry in hopes he can fix it or suggest a workaround.

      This issue actually consists of two parts:

      • Normal TAN-SIP WCS cannot be written as FITS-WCS header cards. David Berry has implement a fix for that problem.
      • WCS rotated by rotateWcsPixelsBy90 cannot be written as FITS-WCS. I have split that into a separate ticket: DM-13564.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            One comment about updating the commit message. Please also note here where the better test is in DM-10765.

            Show
            Parejkoj John Parejko added a comment - One comment about updating the commit message. Please also note here where the better test is in DM-10765 .
            Hide
            rowen Russell Owen added a comment - - edited

            Thanks for the quick review.

            Note that for the starlink_ast package I merged master directly into lsst-dev, as per Tim Jenness's request when there are no local changes associated with a ticket. That means the ticket branch will remain un-merged.

            Show
            rowen Russell Owen added a comment - - edited Thanks for the quick review. Note that for the starlink_ast package I merged master directly into lsst-dev, as per Tim Jenness 's request when there are no local changes associated with a ticket. That means the ticket branch will remain un-merged.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                John Parejko
                Watchers:
                Jim Bosch, John Parejko, Lauren MacArthur, Russell Owen, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel