# Update visualizeVisit following makeImageFromCamera change

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Team:
External

#### Description

In skyCorrection's logs, I see a lot of Unable to fit image for detector "1_47" into image of camera for the focus CCDs and ccd=9. That didn't seem too surprising as I didn't process the focus CCDs and ccd=9. But with a quick look at DM-13437 I'm not so sure. (DM-13437 was merged before _06) Should I expect "Unable to get image for detector instead?

The reason is that visualizeVisit hasn't been updated along the same lines as constructCalibs.

#### Activity

Hide
Paul Price added a comment -

Hsin-Fang Chiang, would you mind reviewing this, please?

 price@pap-laptop:~/LSST/pipe_drivers (tickets/DM-13548=) $git sub commit e66b104805d93bb1efb7272186230ae7037006bc Author: Paul Price  Date: Tue Feb 13 17:41:46 2018 -0500    constructCalibs: use visualizeVisit    to construct the full-focal-plane image. This reduces code duplication.    python/lsst/pipe/drivers/constructCalibs.py | 22 ++--------------------  1 file changed, 2 insertions(+), 20 deletions(-)   commit c14cb7376ad8bcd30c2c7f8d3d908e77e95bd615 (HEAD -> tickets/DM-13548, origin/tickets/DM-13548) Author: Paul Price  Date: Tue Feb 13 17:45:03 2018 -0500    visualizeVisit: provide dummy image if none available    Instead of providing a single-pixel image that will result in a  warning from makeImageFromCamera, we have the information to create  a dummy image of NANs that can do the job instead.    python/lsst/pipe/drivers/visualizeVisit.py | 10 +++++++---  1 file changed, 7 insertions(+), 3 deletions(-)  Show Paul Price added a comment - Hsin-Fang Chiang , would you mind reviewing this, please? price@pap-laptop:~/LSST/pipe_drivers (tickets/DM-13548=)$ git sub commit e66b104805d93bb1efb7272186230ae7037006bc Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 13 17:41:46 2018 -0500   constructCalibs: use visualizeVisit to construct the full-focal-plane image. This reduces code duplication.   python/lsst/pipe/drivers/constructCalibs.py | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-)   commit c14cb7376ad8bcd30c2c7f8d3d908e77e95bd615 (HEAD -> tickets/DM-13548, origin/tickets/DM-13548) Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 13 17:45:03 2018 -0500   visualizeVisit: provide dummy image if none available Instead of providing a single-pixel image that will result in a warning from makeImageFromCamera, we have the information to create a dummy image of NANs that can do the job instead.   python/lsst/pipe/drivers/visualizeVisit.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Hide
Hsin-Fang Chiang added a comment -

I tried this with a skyCorr task, and no longer see those "Unable to fit image for detector "0_51" into image of camera" messages.

Show
Hsin-Fang Chiang added a comment - I tried this with a skyCorr task, and no longer see those "Unable to fit image for detector "0_51" into image of camera" messages.
Hide
Paul Price added a comment -

Jenkins is green (which was pretty likely since not much of what I changed is tested, but I thought it might be good to check just in case).

Show
Paul Price added a comment - Jenkins  is green (which was pretty likely since not much of what I changed is tested, but I thought it might be good to check just in case).
Hide
Paul Price added a comment -

Merged to master.

Thanks Hsin-Fang Chiang!

Show
Paul Price added a comment - Merged to master. Thanks Hsin-Fang Chiang !

#### People

Assignee:
Paul Price
Reporter:
Paul Price
Reviewers:
Hsin-Fang Chiang
Watchers:
Hsin-Fang Chiang, Paul Price