Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13548

Update visualizeVisit following makeImageFromCamera change

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
      None
    • Team:
      External

      Description

      Hsin-Fang Chiang asked:

      In skyCorrection's logs, I see a lot of Unable to fit image for detector "1_47" into image of camera for the focus CCDs and ccd=9. That didn't seem too surprising as I didn't process the focus CCDs and ccd=9. But with a quick look at DM-13437 I'm not so sure. (DM-13437 was merged before _06) Should I expect "Unable to get image for detector instead?

      The reason is that visualizeVisit hasn't been updated along the same lines as constructCalibs.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13437 Stop calibration product generation from causing lots of warnings/errors due to inability to create pretty pictures

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13435 Reprocess RC with w_2018_06

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            price Paul Price created issue -
            Hide
            Permalink
            price Paul Price added a comment -

            Hsin-Fang Chiang, would you mind reviewing this, please?

            price@pap-laptop:~/LSST/pipe_drivers (tickets/DM-13548=) $ git sub
            		 
            commit e66b104805d93bb1efb7272186230ae7037006bc
            		 
            Author: Paul Price <price@astro.princeton.edu>
            		 
            Date:   Tue Feb 13 17:41:46 2018 -0500
            		 
             
            		 
                constructCalibs: use visualizeVisit
            		 
                
                to construct the full-focal-plane image. This reduces code duplication.
            		 
             
            		 
             python/lsst/pipe/drivers/constructCalibs.py | 22 ++--------------------
            		 
             1 file changed, 2 insertions(+), 20 deletions(-)
            		 
             
            		 
            commit c14cb7376ad8bcd30c2c7f8d3d908e77e95bd615 (HEAD -> tickets/DM-13548, origin/tickets/DM-13548)
            		 
            Author: Paul Price <price@astro.princeton.edu>
            		 
            Date:   Tue Feb 13 17:45:03 2018 -0500
            		 
             
            		 
                visualizeVisit: provide dummy image if none available
            		 
                
                Instead of providing a single-pixel image that will result in a
            		 
                warning from makeImageFromCamera, we have the information to create
            		 
                a dummy image of NANs that can do the job instead.
            		 
             
            		 
             python/lsst/pipe/drivers/visualizeVisit.py | 10 +++++++---
            		 
             1 file changed, 7 insertions(+), 3 deletions(-)

            Show
            price Paul Price added a comment - Hsin-Fang Chiang , would you mind reviewing this, please? price@pap-laptop:~/LSST/pipe_drivers (tickets/DM-13548=) $ git sub commit e66b104805d93bb1efb7272186230ae7037006bc Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 13 17:41:46 2018 -0500   constructCalibs: use visualizeVisit to construct the full-focal-plane image. This reduces code duplication.   python/lsst/pipe/drivers/constructCalibs.py | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-)   commit c14cb7376ad8bcd30c2c7f8d3d908e77e95bd615 (HEAD -> tickets/DM-13548, origin/tickets/DM-13548) Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 13 17:45:03 2018 -0500   visualizeVisit: provide dummy image if none available Instead of providing a single-pixel image that will result in a warning from makeImageFromCamera, we have the information to create a dummy image of NANs that can do the job instead.   python/lsst/pipe/drivers/visualizeVisit.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
            price Paul Price made changes -
            Field Original Value New Value
            Reviewers Hsin-Fang Chiang [ hchiang2 ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            price Paul Price made changes -
            Link This issue relates to DM-13437 [ DM-13437 ]
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            I tried this with a skyCorr task, and no longer see those "Unable to fit image for detector "0_51" into image of camera" messages.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - I tried this with a skyCorr task, and no longer see those "Unable to fit image for detector "0_51" into image of camera" messages.
            hchiang2 Hsin-Fang Chiang made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            hchiang2 Hsin-Fang Chiang made changes -
            Link This issue relates to DM-13435 [ DM-13435 ]
            Hide
            Permalink
            price Paul Price added a comment -

            Jenkins is green (which was pretty likely since not much of what I changed is tested, but I thought it might be good to check just in case).

            Show
            price Paul Price added a comment - Jenkins  is green (which was pretty likely since not much of what I changed is tested, but I thought it might be good to check just in case).
            Hide
            Permalink
            price Paul Price added a comment -

            Merged to master.

            Thanks Hsin-Fang Chiang!

            Show
            price Paul Price added a comment - Merged to master. Thanks Hsin-Fang Chiang !
            price Paul Price made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.