XMLWordPrintable

## Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
0.5
• Sprint:
AP S18-3
• Team:

## Description

At present stalrink_ast is built using optimization level 2. I propose to build it with our standard optimization level of 3 in hope of increasing performance.

## Activity

Hide
Russell Owen added a comment - - edited

Please let me know if I changed the correct files.

I will not merge until two Jenkins runs complete: one using master (since that's what most users will see initially) and one using DM-10765 (since it works AST harder and so is more likely to expose problems – not that I anticipate any).

I verified that when I build on my Mac and on lsst-dev I see -O3 instead of -O2 but I could not think of any other way to confirm that the change has the desired effect.

Show
Russell Owen added a comment - - edited Please let me know if I changed the correct files. I will not merge until two Jenkins runs complete: one using master (since that's what most users will see initially) and one using DM-10765 (since it works AST harder and so is more likely to expose problems – not that I anticipate any). I verified that when I build on my Mac and on lsst-dev I see -O3 instead of -O2 but I could not think of any other way to confirm that the change has the desired effect.
Hide
Tim Jenness added a comment -

This does seem to work. We'll have to watch out that we don't lose this setting when we regenerate the configure script. It might have been less of a maintenance issue to set CFLAGS and FCFLAGS in the eupspkg.cfg.sh (which I see is sort of what I did in my Starlink build system where I use a config.site file in $PREFIX/etc where I do use -O3). Show Tim Jenness added a comment - This does seem to work. We'll have to watch out that we don't lose this setting when we regenerate the configure script. It might have been less of a maintenance issue to set CFLAGS and FCFLAGS in the eupspkg.cfg.sh (which I see is sort of what I did in my Starlink build system where I use a config.site file in$PREFIX/etc where I do use -O3 ).
Hide
Tim Jenness added a comment -

I think this works:

 diff --git a/ups/eupspkg.cfg.sh b/ups/eupspkg.cfg.sh index 186efc8..e838c57 100644 --- a/ups/eupspkg.cfg.sh +++ b/ups/eupspkg.cfg.sh @@ -1,3 +1,5 @@  # EupsPkg config file. Sourced by 'eupspkg'   +export CFLAGS="-g -O3" +export FCFLAGS="-g -O3"  CONFIGURE_OPTIONS="--prefix=$PREFIX --libdir=$PREFIX/lib --without-fortran --without-stardocs --without-pthreads" 

Show
Tim Jenness added a comment - I think this works: diff --git a/ups/eupspkg.cfg.sh b/ups/eupspkg.cfg.sh index 186efc8..e838c57 100644 --- a/ups/eupspkg.cfg.sh +++ b/ups/eupspkg.cfg.sh @@ -1,3 +1,5 @@ # EupsPkg config file. Sourced by 'eupspkg' +export CFLAGS="-g -O3" +export FCFLAGS="-g -O3" CONFIGURE_OPTIONS="--prefix=$PREFIX --libdir=$PREFIX/lib --without-fortran --without-stardocs --without-pthreads"
Hide
Russell Owen added a comment - - edited

That does work and seems much better. I modified the ticket branch accordingly.

My version appends -g -O3 to the existing CFLAGS (as is done in two other packages) and does not set FCFLAGS since we don't need that set. I made sure it did the expected thing on my Mac and on lsst-dev.

Show
Russell Owen added a comment - - edited That does work and seems much better. I modified the ticket branch accordingly. My version appends -g -O3 to the existing CFLAGS (as is done in two other packages) and does not set FCFLAGS since we don't need that set. I made sure it did the expected thing on my Mac and on lsst-dev.

## People

• Assignee:
Russell Owen
Reporter:
Russell Owen
Reviewers:
Tim Jenness
Watchers:
Russell Owen, Tim Jenness