Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13575

fix minor bug in photometry ipynb

    XMLWordPrintable

    Details

      Description

      While looking at HSC data, I noticed that my on-sky dependence plots were not handling the initial dataset correctly. I've fixed that, but it should be committed separately from other open tickets.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          John Swinbank, you said you'd review this! The change is making plot_fluxes(initial, final) take initial and final and using those separately, because final['inputFlux'] - final['fittedFlux'] doesn't mean what one might think it means.

          Show
          Parejkoj John Parejko added a comment - John Swinbank , you said you'd review this! The change is making plot_fluxes(initial, final) take initial and final and using those separately, because final ['inputFlux'] - final ['fittedFlux'] doesn't mean what one might think it means.
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          We discussed offline; I'm happy with this.

          Show
          swinbank John Swinbank added a comment - We discussed offline; I'm happy with this.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Thanks for the review: I updated the commit message and it should make the fix much clearer.

          Show
          Parejkoj John Parejko added a comment - Thanks for the review: I updated the commit message and it should make the fix much clearer.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            John Swinbank
            Watchers:
            Dominique Boutigny, John Parejko, John Swinbank
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: