# tempWideBackground isn't temporary

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Team:
External

#### Description

Hiroyuki Ikeda (NAOJ) noticed that the temporary wide background (DM-13553) we remove when we detect sources on the coadds isn't being properly restored, leading to the over-subtraction of sources in large galaxies.

#### Activity

Hide
Paul Price added a comment -

 price@pap-laptop:~/LSST/meas_algorithms (tickets/DM-13617=) $git sub commit 77cbf9fff51a66c4591dacb7415cfc192f773c42 (HEAD -> tickets/DM-13617, origin/tickets/DM-13617) Author: Paul Price  Date: Thu Feb 22 11:19:55 2018 -0500    detection: fix restoration of tempWideBackground    We weren't restoring the original image because we didn't have a copy  of it.    python/lsst/meas/algorithms/detection.py | 2 +-  tests/test_detection.py | 32 ++++++++++++++++++++++++++++++++  2 files changed, 33 insertions(+), 1 deletion(-)  Show Paul Price added a comment - price@pap-laptop:~/LSST/meas_algorithms (tickets/DM-13617=)$ git sub commit 77cbf9fff51a66c4591dacb7415cfc192f773c42 (HEAD -> tickets/DM-13617, origin/tickets/DM-13617) Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 22 11:19:55 2018 -0500   detection: fix restoration of tempWideBackground We weren't restoring the original image because we didn't have a copy of it.   python/lsst/meas/algorithms/detection.py | 2 +- tests/test_detection.py | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-)
Hide
Paul Price added a comment -

Jim Bosch, would you mind looking at this, please?

Jenkins is running.

Show
Paul Price added a comment - Jim Bosch , would you mind looking at this, please? Jenkins is running.
Hide
Jim Bosch added a comment -

Looks good, but the test code may not be testing much (should be a trivial fix).  Comments on the PR.

Show
Jim Bosch added a comment - Looks good, but the test code may not be testing much (should be a trivial fix).  Comments on the PR.
Hide
Paul Price added a comment -

Doh! Thanks for spotting that. Put in a fixup commit that you can check if you like while I re-run Jenkins.

Show
Paul Price added a comment - Doh! Thanks for spotting that. Put in a fixup commit that you can check if you like while I re-run Jenkins.
Hide
Paul Price added a comment -

The latest Jenkins is still running OSX, but the one before was fine. Given that the only difference is the test fix, and that's going through fine, I've merged to master.

Show
Paul Price added a comment - The latest Jenkins is still running OSX, but the one before was fine. Given that the only difference is the test fix, and that's going through fine, I've merged to master.

#### People

Assignee:
Paul Price
Reporter:
Paul Price
Reviewers:
Jim Bosch
Watchers:
Jim Bosch, Paul Price