Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13617

tempWideBackground isn't temporary

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
    • Team:
      External

      Description

      Hiroyuki Ikeda (NAOJ) noticed that the temporary wide background (DM-13553) we remove when we detect sources on the coadds isn't being properly restored, leading to the over-subtraction of sources in large galaxies.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          price@pap-laptop:~/LSST/meas_algorithms (tickets/DM-13617=) $ git sub
          commit 77cbf9fff51a66c4591dacb7415cfc192f773c42 (HEAD -> tickets/DM-13617, origin/tickets/DM-13617)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Feb 22 11:19:55 2018 -0500
           
              detection: fix restoration of tempWideBackground
              
              We weren't restoring the original image because we didn't have a copy
              of it.
           
           python/lsst/meas/algorithms/detection.py |  2 +-
           tests/test_detection.py                  | 32 ++++++++++++++++++++++++++++++++
           2 files changed, 33 insertions(+), 1 deletion(-)
          

          Show
          price Paul Price added a comment - price@pap-laptop:~/LSST/meas_algorithms (tickets/DM-13617=) $ git sub commit 77cbf9fff51a66c4591dacb7415cfc192f773c42 (HEAD -> tickets/DM-13617, origin/tickets/DM-13617) Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 22 11:19:55 2018 -0500   detection: fix restoration of tempWideBackground We weren't restoring the original image because we didn't have a copy of it.   python/lsst/meas/algorithms/detection.py | 2 +- tests/test_detection.py | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-)
          Hide
          price Paul Price added a comment -

          Jim Bosch, would you mind looking at this, please?

          Jenkins is running.

          Show
          price Paul Price added a comment - Jim Bosch , would you mind looking at this, please? Jenkins is running.
          Hide
          jbosch Jim Bosch added a comment -

          Looks good, but the test code may not be testing much (should be a trivial fix).  Comments on the PR.

          Show
          jbosch Jim Bosch added a comment - Looks good, but the test code may not be testing much (should be a trivial fix).  Comments on the PR.
          Hide
          price Paul Price added a comment -

          Doh! Thanks for spotting that. Put in a fixup commit that you can check if you like while I re-run Jenkins.

          Show
          price Paul Price added a comment - Doh! Thanks for spotting that. Put in a fixup commit that you can check if you like while I re-run Jenkins.
          Hide
          price Paul Price added a comment -

          The latest Jenkins is still running OSX, but the one before was fine. Given that the only difference is the test fix, and that's going through fine, I've merged to master.

          Show
          price Paul Price added a comment - The latest Jenkins is still running OSX, but the one before was fine. Given that the only difference is the test fix, and that's going through fine, I've merged to master.

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: