Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13630

Image distance tool fails in particular case where some images searched were not found

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:

      Description

      When searching images, sometimes there are images that are not found or the area searched is not covered by the dataset chosen. Example: search for m34 on SEIP, see last image (MIPS24 is missing because no image is covering this target).

      The result can be a mix of rendered images and failed images. When this happen, the following operations on images failed (maybe others): distance tool offset calculation and flipping around axis.

      It happens in Firefly tri-view and IRSA apps (FC/IV).

        Attachments

          Issue Links

            Activity

            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Tested on the current dev. Y-axis flip failed for me. I checked console and saw the following error. The NULL could be caused by the failed image. 

            HandlePlotChange.js:467 Uncaught TypeError: Cannot read property 'getImageCoords' of null
            at flipPv (HandlePlotChange.js:467)
            at HandlePlotChange.js:484
            at PlotViewUtil.js:491
            at Array.map (<anonymous>)
            at applyToOnePvOrGroup (PlotViewUtil.js:486)
            at updateClientFlip (HandlePlotChange.js:484)
            at reducer (HandlePlotChange.js:112)
            at reducer (ImagePlotCntlr.js:989)
            at combination (combineReducers.js:120)
            at dispatch (createStore.js:165)

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Tested on the current dev. Y-axis flip failed for me. I checked console and saw the following error. The NULL could be caused by the failed image.  HandlePlotChange.js:467 Uncaught TypeError: Cannot read property 'getImageCoords' of null at flipPv (HandlePlotChange.js:467) at HandlePlotChange.js:484 at PlotViewUtil.js:491 at Array.map (<anonymous>) at applyToOnePvOrGroup (PlotViewUtil.js:486) at updateClientFlip (HandlePlotChange.js:484) at reducer (HandlePlotChange.js:112) at reducer (ImagePlotCntlr.js:989) at combination (combineReducers.js:120) at dispatch (createStore.js:165)
            Hide
            roby Trey Roby added a comment - - edited

            Note: I fixed the  flip bug, I could not duplicate a distance tool bug.

            Show
            roby Trey Roby added a comment - - edited Note: I fixed the  flip bug, I could not duplicate a distance tool bug.

              People

              • Assignee:
                roby Trey Roby
                Reporter:
                ejoliet Emmanuel Joliet
                Reviewers:
                Dean Naji
                Watchers:
                Cindy Wang [X] (Inactive), Dean Naji, Emmanuel Joliet, Trey Roby, Xiuqin Wu [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel