Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Firefly
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2019-03
-
Team:Science User Interface
Description
When searching images, sometimes there are images that are not found or the area searched is not covered by the dataset chosen. Example: search for m34 on SEIP, see last image (MIPS24 is missing because no image is covering this target).
The result can be a mix of rendered images and failed images. When this happen, the following operations on images failed (maybe others): distance tool offset calculation and flipping around axis.
It happens in Firefly tri-view and IRSA apps (FC/IV).
Attachments
Issue Links
- relates to
-
- Done
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
When searching images, sometimes there are images that are not found or the area searched is not covered by the dataset chosen. Example: search for m34 on SEIP
The result can be a mix of rendered images and failed images. When this happen, the following operations on images failed (maybe others): distance tool offset calculation and flipping around axis. It happens in Firefly tri-view and IRSA apps (FC/IV). |
When searching images, sometimes there are images that are not found or the area searched is not covered by the dataset chosen. Example: search for m34 on SEIP, see last image (MIPS24 is missing because no image is covering this target).
The result can be a mix of rendered images and failed images. When this happen, the following operations on images failed (maybe others): distance tool offset calculation and flipping around axis. It happens in Firefly tri-view and IRSA apps (FC/IV). |
| Epic Link |
|
| Assignee | Trey Roby [ roby ] |
| Sprint | SUIT Sprint 2019-3 [ 860 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Cindy Wang [ cwang ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Remote Link | This issue links to "Pull Request (Web Link)" [ 20009 ] |
| Status | In Review [ 10004 ] | In Progress [ 3 ] |
| Reviewers | Cindy Wang [ cwang ] | Dean Naji [ dnaji ] |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Note: I fixed the flip bug, I could not duplicate a distance tool bug.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Story Points | 2 |
Tested on the current dev. Y-axis flip failed for me. I checked console and saw the following error. The NULL could be caused by the failed image.
HandlePlotChange.js:467 Uncaught TypeError: Cannot read property 'getImageCoords' of null
at flipPv (HandlePlotChange.js:467)
at HandlePlotChange.js:484
at PlotViewUtil.js:491
at Array.map (<anonymous>)
at applyToOnePvOrGroup (PlotViewUtil.js:486)
at updateClientFlip (HandlePlotChange.js:484)
at reducer (HandlePlotChange.js:112)
at reducer (ImagePlotCntlr.js:989)
at combination (combineReducers.js:120)
at dispatch (createStore.js:165)