Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13669

Track and log measurement/reference outliers separately

    XMLWordPrintable

    Details

      Description

      jointcal currently tracks the total number of outliers per minimization step ("INFO: Total number of outliers 2578"). We should change that to separately track measurement and reference outliers so that we can compare them independently.

      With this, we can plot the number of each type of outlier that was removed per fitting step, which can help tell us something about how stable the fit is. (see the final plot in Dominique's Astrometry.ipynb)

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-13670 Check residual vs. errors for photometry

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-13671 Add option to skip cholmod.update step

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            This is an easy fix that should help debugging DM-13670 and DM-13671

            Show
            Parejkoj John Parejko added a comment - This is an easy fix that should help debugging DM-13670 and DM-13671
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen Do you mind doing this short C++ review?

            There's also a new jupyter notebook that I wrote to look at the output from this, but the plots in it aren't very interesting yet, as I mostly just used them to confirm that the output was sensible, before I start using them for actual live debugging.

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen Do you mind doing this short C++ review? There's also a new jupyter notebook that I wrote to look at the output from this, but the plots in it aren't very interesting yet, as I mostly just used them to confirm that the output was sensible, before I start using them for actual live debugging.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good. Couple of redundancy-related questions on the PR.

            Show
            krzys Krzysztof Findeisen added a comment - Looks good. Couple of redundancy-related questions on the PR.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27757/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27757/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review. I revised some comments and log messages.

            Merged and done. (and the first real test of travis+flake8 for jointcal!)

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review. I revised some comments and log messages. Merged and done. (and the first real test of travis+flake8 for jointcal!)

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Dominique Boutigny, John Parejko, John Swinbank, Krzysztof Findeisen, Pierre Astier
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.