Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_subaru
-
Labels:
-
Team:External
Description
Hisanori Furusawa has identified additional HSC defects that should be masked. He writes:
In this updates, I have added a mask to ccd=76 as well as ccd=33 and
43, as we found some affected area by bad pixels especially in NB0387.
Also I removed an unnecessary mask in ccd=43 which was mistakenly
placed for early period (before 2016-04).The top-left corner of ccd=33 and 43 look quite bright on dark images
in some periods, but we determiend the areas to be masked on CORR
images both for typical broad-band (mostly HSC-G), and the worst
affected NB0387.
Attachments
Activity
The masked areas cover the bad looking areas on the chips and the removed lines were all ones which were commented out, looks good to me.
> In this updates, I have added a mask to ccd=76 as well as ccd=33 and
sorry, but this should read ccd=74 as well as ccd=33. thank you very much for reviewing.
Hisanori Furusawa
added a comment - > In this updates, I have added a mask to ccd=76 as well as ccd=33 and
sorry, but this should read ccd=74 as well as ccd=33. thank you very much for reviewing. I've updated the commit message with Furusawa-san's change.
Jenkins passed, mostly: all except OSX, which failed with system problems.
Merged to master.
Paul Price
added a comment - I've updated the commit message with Furusawa-san's change.
Jenkins passed, mostly: all except OSX, which failed with system problems.
Merged to master. 
Thanks for volunteering to review, Sophie Reed!
price@pap-laptop:~/LSST/obs_subaru (tickets/DM-13731=) $ git subcommit 18907f52d5d06d84cfcc69f1a3938930f2d506a7Author: Paul Price <price@astro.princeton.edu>Date: Wed Mar 7 15:09:50 2018 -0800hsc: add more defects from Furusawa-sanFurusawa-san writes:> In this updates, I have added a mask to ccd=76 as well as> ccd=33 and 43, as we found some affected area by bad pixels> specially in NB0387. Also I removed an unnecessary mask in> ccd=43 which was mistakenly placed for early period (before> 2016-04).>> The top-left corner of ccd=33 and 43 look quite bright on> dark images in some periods, but we determiend the areas> to be masked on CORR images both for typical broad-band> (mostly HSC-G), and the worst affected NB0387.hsc/defects/2013-01-31/defects.dat | 11 +-hsc/defects/2014-04-03/defects.dat | 11 +-hsc/defects/2014-06-01/defects.dat | 11 +-hsc/defects/2015-11-06/defects.dat | 814 +++++++++++++++++++++++++++++++++++++hsc/defects/2016-04-01/defects.dat | 11 +-hsc/defects/2016-11-22/defects.dat | 9 +hsc/defects/2016-12-23/defects.dat | 9 +7 files changed, 869 insertions(+), 7 deletions(-)commit 1c626c09ea26ca9f6280e7b3c6443df1de863173 (HEAD -> tickets/DM-13731, origin/tickets/DM-13731)Author: Paul Price <price@astro.princeton.edu>Date: Wed Mar 7 15:13:30 2018 -0800hsc: remove commented-out defectsSome defects had been commented-out instead of removed;they have now been removed.hsc/defects/2013-01-31/defects.dat | 2 --hsc/defects/2014-04-03/defects.dat | 4 ----hsc/defects/2014-06-01/defects.dat | 3 ---hsc/defects/2016-04-01/defects.dat | 3 ---hsc/defects/2016-11-22/defects.dat | 3 ---hsc/defects/2016-12-23/defects.dat | 2 --6 files changed, 17 deletions(-)