Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13738

Remove exposureId from visitInfo

    XMLWordPrintable

Details

    • Bug
    • Status: Invalid
    • Resolution: Done
    • None
    • afw

    Description

      exposureId in visitInfo is not a visit-exposure level identifier, but rather a ccd-exposure level identifier (see docstring for obs.base.CameraMapper._computeCcdExposureId() for the only place where this seems to be specified). Thus, it should not be included in visitInfo, which is only things that are common across the visit. exposureId should be moved back into ExposureInfo.

      We do need a visit-exposure level identifier to be included in visitInfo, so that we can link exposures within visits without using the butler (e.g. without dataRef.dataId['visit']). We could have makeRawVisitInfo() add the butler visitId to the new visitInfo.visitId that this ticket will add.

      Marking this Critical because we should fix this ASAP, before use of visitInfo.exposureId becomes widespread. This is an API-breaking change, so it may need an RFC?

      See this discussion that generated this ticket:

      https://lsstc.slack.com/archives/C3UCAEW3D/p1517724549000034

      Attachments

        Issue Links

          Activity

            erykoff Eli Rykoff added a comment -

            (a) I wholeheartedly endorse this, but (b) I'm pretty sure it requires an RFC.

            erykoff Eli Rykoff added a comment - (a) I wholeheartedly endorse this, but (b) I'm pretty sure it requires an RFC.
            rowen Russell Owen added a comment -

            Thank you for the RFC. Well done.

            rowen Russell Owen added a comment - Thank you for the RFC. Well done.
            dtaranu Dan Taranu added a comment -

            The RFC has been adopted. Parejkoj, do you want to claim credit for this and mark it done?

            dtaranu Dan Taranu added a comment - The RFC has been adopted. Parejkoj , do you want to claim credit for this and mark it done?
            tjenness Tim Jenness added a comment -

            The work hasn't been done. RFCs in adopted state are RFCs where we have agreed to do the work but the work is still to be done. Implemented means that the work has been completed.

            tjenness Tim Jenness added a comment - The work hasn't been done. RFCs in adopted state are RFCs where we have agreed to do the work but the work is still to be done. Implemented means that the work has been completed.
            dtaranu Dan Taranu added a comment -

            The RFC has an epic with two additional tickets to implement it. That would seem to make this ticket redundant.

            dtaranu Dan Taranu added a comment - The RFC has an epic with two additional tickets to implement it. That would seem to make this ticket redundant.
            tjenness Tim Jenness added a comment -

            It could be argued that this ticket is a duplicate of DM-13943. Maybe Parejkoj wants to comment since he filed this.

            tjenness Tim Jenness added a comment - It could be argued that this ticket is a duplicate of DM-13943 . Maybe Parejkoj wants to comment since he filed this.
            Parejkoj John Parejko added a comment -

            Marking this as a duplicate of DM-13943: I think that ticket has the better approach (moving it out of VisitInfo and into ExposureInfo, where it belongs). Doing that will take care of this.

            Parejkoj John Parejko added a comment - Marking this as a duplicate of DM-13943 : I think that ticket has the better approach (moving it out of VisitInfo and into ExposureInfo, where it belongs). Doing that will take care of this.

            People

              Unassigned Unassigned
              Parejkoj John Parejko
              Dan Taranu, Eli Rykoff, Jim Bosch, John Parejko, John Swinbank, Kian-Tat Lim, Michael Wood-Vasey, Russell Owen, Simon Krughoff (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.