Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13742

Fix plot names to include filter. Add outputPrefix option to validateDrp.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Output plots don't get the filtername. This is an omission in the outputPrefix being passed to plot_metrics:

      if makePlot:
          plot_metrics(job, filterName, outputPrefix=outputPrefix)
      

      should be

      if makePlot:
          if outputPrefix is None or outputPrefix == '':
              thisOutputPrefix = "%s" % filterName
          else:
              thisOutputPrefix = "%s_%s" % (outputPrefix, filterName)
          plot_metrics(job, filterName, outputPrefix=thisOutputPrefix)
      

        Attachments

          Activity

          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Simple change. Should get filter names included in plot filenames to ensure things are appropriately unique. Passed Jenkins.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Simple change. Should get filter names included in plot filenames to ensure things are appropriately unique. Passed Jenkins.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Sorry for the delay. Comments on the PR. 

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Sorry for the delay. Comments on the PR. 
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Comments in PR addressed. Thanks!

          Merged to master.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Comments in PR addressed. Thanks! Merged to master.

            People

            Assignee:
            wmwood-vasey Michael Wood-Vasey
            Reporter:
            wmwood-vasey Michael Wood-Vasey
            Reviewers:
            Hsin-Fang Chiang
            Watchers:
            Hsin-Fang Chiang, Michael Wood-Vasey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.