Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13744

Run clang-tidy checks and cleanup on afw

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The clang-tidy tool provides a long list of checks that can automatically modernize and fix-up C++ code. Determine a sensible (not-too-intrusive) subset and run them on afw.

      The full list of possible checks can be found at: https://clang.llvm.org/extra/clang-tidy/checks/list.html

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            I ran a subset of the available checks. The full list of possible checks can be found at https://clang.llvm.org/extra/clang-tidy/checks/list.html. Each check was run independently and only those that resulted in changes are listed as a separate commit (that can be easily removed if deemed too intrusive).

            Please go through and see what you think.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - I ran a subset of the available checks. The full list of possible checks can be found at https://clang.llvm.org/extra/clang-tidy/checks/list.html . Each check was run independently and only those that resulted in changes are listed as a separate commit (that can be easily removed if deemed too intrusive). Please go through and see what you think.
            Hide
            jbosch Jim Bosch added a comment -

            Matthias Wittgen, you've talked about doing this in the past, and you're not the first one. I'm not sure this ticket is useful (I'm sure the branch isn't mergeable, as it was created ages ago and a new clang-tidy run would be quite different), but there maybe useful information here, and if you don't have your own ticket to do this you're welcome to use this one.

            Show
            jbosch Jim Bosch added a comment - Matthias Wittgen , you've talked about doing this in the past, and you're not the first one. I'm not sure this ticket is useful (I'm sure the branch isn't mergeable, as it was created ages ago and a new clang-tidy run would be quite different), but there maybe useful information here, and if you don't have your own ticket to do this you're welcome to use this one.
            Hide
            wittgen Matthias Wittgen added a comment -

            Cloned into new task to avoid messing with already existing branches for this ticket in github

            Show
            wittgen Matthias Wittgen added a comment - Cloned into new task to avoid messing with already existing branches for this ticket in github

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, Krzysztof Findeisen, Matthias Wittgen, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.