Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13768

Fix firefly_client uploads to work with server on https

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: SUIT
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      SUIT Sprint 2018-03
    • Team:
      Science User Interface

      Description

      The Jellybean environment includes a Firefly server with an https url. Uploads are unsuccessful with the current firefly_client.

       

      • Fix the upload functions to use the base url in the client
      • Tag as a bug fix release
      • Deploy to PyPI for pip installation
      • Sync to the firefly_client repo on the LSST Github org
      • In the lsst.display.firefly backend, remove the port argument
      • Change docs and examples for lsst.display.firefly to remove the port argument
      • Substantially shorten the Installation portion of the docs, now that lsst.display.firefly is included in lsst_distrib.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12797 Firefly version of DM stack tutorial

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-13786 'FireflyClient' object has no attribute 'headers'

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            shupe David Shupe added a comment -

            Pull request at https://github.com/Caltech-IPAC/firefly_client/pull/19

            Show
            shupe David Shupe added a comment - Pull request at  https://github.com/Caltech-IPAC/firefly_client/pull/19
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I reviewed the display_firefly changes on the PR.

            Show
            krughoff Simon Krughoff added a comment - I reviewed the display_firefly changes on the PR.
            Hide
            Permalink
            shupe David Shupe added a comment -

            New postfix pull request for firefly_client at https://github.com/Caltech-IPAC/firefly_client/pull/20, not yet ready for final review but a place where we can discuss how to handle the headers in FireflyClient initialization.

            Show
            shupe David Shupe added a comment - New postfix pull request for firefly_client at https://github.com/Caltech-IPAC/firefly_client/pull/20 , not yet ready for final review but a place where we can discuss how to handle the headers in FireflyClient initialization.
            Hide
            Permalink
            shupe David Shupe added a comment -

            We have decided that when channel=None is passed to FireflyClient, then on the Python side we will initialize channel to a unique string. The [PR on firefly_client|https://github.com/Caltech-IPAC/firefly_client/pull/20] is ready for review

            Show
            shupe David Shupe added a comment - We have decided that when channel=None is passed to FireflyClient , then on the Python side we will initialize channel to a unique string. The [PR on firefly_client| https://github.com/Caltech-IPAC/firefly_client/pull/20 ] is ready for review
            Hide
            Permalink
            shupe David Shupe added a comment -

            Reviews were completed on the three pull request on Github (two PRs on firefly_client, one PR on display_firefly). All PRs have been merged.

            Show
            shupe David Shupe added a comment - Reviews were completed on the three pull request on Github (two PRs on firefly_client , one PR on display_firefly ). All PRs have been merged.

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Reviewers:
              Simon Krughoff, Trey Roby
              Watchers:
              David Shupe, Simon Krughoff, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.