Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13788

Remove mariadbclient dependency from daf_persistence

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_persistence
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          npease Nate Pease [X] (Inactive) added a comment -

          As I understand it the goal here is to do an easy extraction of an unused dependency (mariadbclient) so it can be updated without disrupting other dependencies with common sub dependencies. Given that, it shouldn't take more than a day or 2 to do this, and if it does we should reevaluate our decision to remove the mariadbclient dependency.

          Show
          npease Nate Pease [X] (Inactive) added a comment - As I understand it the goal here is to do an easy extraction of an unused dependency (mariadbclient) so it can be updated without disrupting other dependencies with common sub dependencies. Given that, it shouldn't take more than a day or 2 to do this, and if it does we should reevaluate our decision to remove the mariadbclient dependency.
          Hide
          tjenness Tim Jenness added a comment -

          I had a quick look at this and everything looks fine to me. If a full Jenkins build is okay with it I'm happy for the merge to happen.

          Show
          tjenness Tim Jenness added a comment - I had a quick look at this and everything looks fine to me. If a full Jenkins build is okay with it I'm happy for the merge to happen.
          Hide
          ktl Kian-Tat Lim added a comment -

          Sorry I missed the review, but if you get rid of afw/src/formatters/Utils.cc getTableName() and getAllSliceTableNames() you should also be able to remove pex/Policy.h, I think, which would be a good thing.

          Show
          ktl Kian-Tat Lim added a comment - Sorry I missed the review, but if you get rid of afw/src/formatters/Utils.cc getTableName() and getAllSliceTableNames() you should also be able to remove pex/Policy.h , I think, which would be a good thing.

            People

            Assignee:
            npease Nate Pease [X] (Inactive)
            Reporter:
            fritzm Fritz Mueller
            Reviewers:
            Kian-Tat Lim
            Watchers:
            Fritz Mueller, Kian-Tat Lim, Nate Pease [X] (Inactive), Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.