Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13796

Fix minor issues in cat schema files

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cat
    • Labels:

      Description

      Working on DM-13781 I tried to convert baseline schem to YAML and noticed some minor issues in that schema file:

      • in some comments it uses </desc> instead of </descr>
      • DiaSource index has a name IDX_DiaObject_htmId20
      • DiaSource index IDX_DiaSource_filterName refers to non-existing field name

      Also I need to verify that type of flags field in DiaForcedSource is correct (TINYINT)

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            DPDD does not define DiaForcedSource schema but for DiaSource it specifies flags as 64-bit int. I'm going to change DiaForcedSource flags to be BIGINT for consistency with DiaSource.

            Show
            salnikov Andy Salnikov added a comment - DPDD does not define DiaForcedSource schema but for DiaSource it specifies flags as 64-bit int. I'm going to change DiaForcedSource flags  to be BIGINT for consistency with DiaSource.
            Hide
            salnikov Andy Salnikov added a comment - - edited

            Brian Van Klaveren, can you have a quick look at my changes?

            PR link: https://github.com/lsst/cat/pull/15 (Jira is sort of slow again)

            Show
            salnikov Andy Salnikov added a comment - - edited Brian Van Klaveren , can you have a quick look at my changes? PR link: https://github.com/lsst/cat/pull/15  (Jira is sort of slow again)
            Hide
            bvan Brian Van Klaveren added a comment -

            Looks fine. Good catch on the descr fix, I think the parser fails silently so those weren't getting parsed.

            Show
            bvan Brian Van Klaveren added a comment - Looks fine. Good catch on the descr fix, I think the parser fails silently so those weren't getting parsed.
            Hide
            salnikov Andy Salnikov added a comment -

            Thanks for quick review! Merged and done.

            Show
            salnikov Andy Salnikov added a comment - Thanks for quick review! Merged and done.

              People

              • Assignee:
                salnikov Andy Salnikov
                Reporter:
                salnikov Andy Salnikov
                Reviewers:
                Brian Van Klaveren
                Watchers:
                Andy Salnikov, Brian Van Klaveren
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel