# Update obs_cfht to support flawless image reduction and coaddition

XMLWordPrintable

## Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:

## Activity

Hide
Dominique Boutigny added a comment -

This branch contains all the modifications to get a working version of the CFHT data processing, up to coaddition.

Nothing urgent.

Show
Dominique Boutigny added a comment - This branch contains all the modifications to get a working version of the CFHT data processing, up to coaddition. Nothing urgent.
Hide
Simon Krughoff added a comment -

Comments:
In general things look good. Just a couple of general points. I'd like to reduce code duplication in the subclassed tasks. I think the schema issue in the calibrate task has been fixed on master.

I think this is specified twice in the config:
root.calibrate.repair.cosmicray.nCrPixelMax

python/lsst/obs/cfht/astrometry.py
line 32: We need to make these kinds of things easier, but I think you can get the same effect with less duplicated code by doing:

 from lsst.obs.cfht.cfhtastrom import CfhtAstrometry class CfhtAstrometryTask(pipe.tasks.astrometry.AstrometryTask):  def __init__(self, schema, **kwargs):  pipe.tasks.astrometry.AstrometryTask.__init__(schema, **kwargs)  self.astrometer = CfhtAstrometry(self.config.solver, self.log)

python/lsst/obs/cfht/cfhtCalibrate.py
I think the problem here is fixed on master. Can you try it and remove this if it's no longer needed?

python/lsst/obs/cfht/cfhtastrom.py
line 85: I don't believe ntotal is used.
line 154: Is there a more permanent way to deal with this?

Show
Simon Krughoff added a comment - Comments: In general things look good. Just a couple of general points. I'd like to reduce code duplication in the subclassed tasks. I think the schema issue in the calibrate task has been fixed on master. I think this is specified twice in the config: root.calibrate.repair.cosmicray.nCrPixelMax python/lsst/obs/cfht/astrometry.py line 32: We need to make these kinds of things easier, but I think you can get the same effect with less duplicated code by doing: from lsst.obs.cfht.cfhtastrom import CfhtAstrometry class CfhtAstrometryTask(pipe.tasks.astrometry.AstrometryTask): def __init__( self , schema, * * kwargs): pipe.tasks.astrometry.AstrometryTask.__init__(schema, * * kwargs) self .astrometer = CfhtAstrometry( self .config.solver, self .log) python/lsst/obs/cfht/cfhtCalibrate.py I think the problem here is fixed on master. Can you try it and remove this if it's no longer needed? python/lsst/obs/cfht/cfhtastrom.py line 85: I don't believe ntotal is used. line 154: Is there a more permanent way to deal with this?

## People

• Assignee:
Dominique Boutigny
Reporter:
Dominique Boutigny
Reviewers:
Simon Krughoff
Watchers:
Dominique Boutigny, Simon Krughoff
• Votes:
0 Vote for this issue
Watchers:
2 Start watching this issue

## Dates

• Created:
Updated:
Resolved: