Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13814

Reorganize composites handling in datastore/butler

    Details

      Description

      Following discussions on how composites work we have decided to move assembly/disassembly up a level to Butler.put/get and will change the API of datastore.put/get. URIs will no longer be returned and a separate method will be provided on datastore for creating URIs. Files being stored must now be associated with a datasetref explicitly in datastore registry.

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          Pim Schellart [X] can you please take a look at this. The major functionality is in place.

          Show
          tjenness Tim Jenness added a comment - Pim Schellart [X] can you please take a look at this. The major functionality is in place.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good, modulo comments. But given the size of the PR and the potential of expensive API changes later on, I'd like Jim Bosch to have a quick scan over it. In particular the get/put API, component DatasetType naming, customization points and where/how configuration lives. Just to make sure we don't lock ourselves into something that is hard to change later.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good, modulo comments. But given the size of the PR and the potential of expensive API changes later on, I'd like Jim Bosch to have a quick scan over it. In particular the get/put API, component DatasetType naming, customization points and where/how configuration lives. Just to make sure we don't lock ourselves into something that is hard to change later.
          Hide
          tjenness Tim Jenness added a comment -

          Thanks for the quick review. I've made all the changes. I'm happy to wait for Jim Bosch to take a look.

          Show
          tjenness Tim Jenness added a comment - Thanks for the quick review. I've made all the changes. I'm happy to wait for Jim Bosch to take a look.
          Hide
          jbosch Jim Bosch added a comment -

          Comments on the PR.

          Show
          jbosch Jim Bosch added a comment - Comments on the PR.
          Hide
          tjenness Tim Jenness added a comment -

          Merged. Thanks for the reviews. The issue of the internal registry for Datastore (for storing formatter information) still needs to be resolved (and the current shim is temporary).

          Show
          tjenness Tim Jenness added a comment - Merged. Thanks for the reviews. The issue of the internal registry for Datastore (for storing formatter information) still needs to be resolved (and the current shim is temporary).

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Jim Bosch, Pim Schellart [X] (Inactive)
              Watchers:
              Jim Bosch, Pim Schellart [X] (Inactive), Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel