Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13822

Remove python_mysqlclient dependency from obs_lsstSim and obs_sdss

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsstSim
    • Labels:
      None

      Description

      The dependency on python_mysqlclient in obs_lsstSim is cargo culted from obs_sdss and should be removed.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-464 Remove untested database code from obs_sdss and obs_lsstSim

          • Implemented
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-1690 should testSelectFluxMag0.py use a parent bbox?

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13902 Build of obs_sdss fails because SpherePoint is missing toIcrs

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Looking more closely, obs_lsstSim does, in fact, use MySQLdb, so this isn't as simple as just removing the setupRequired. We need to figure out how best to deal with this.

            Show
            krughoff Simon Krughoff added a comment - Looking more closely, obs_lsstSim does, in fact, use MySQLdb , so this isn't as simple as just removing the setupRequired . We need to figure out how best to deal with this.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            This was decided in RFC-464. We will remove the code that uses MySQLdb from obs_lsstSim and obs_sdss.

            Show
            krughoff Simon Krughoff added a comment - This was decided in RFC-464 . We will remove the code that uses MySQLdb from obs_lsstSim and obs_sdss .
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Tim, can you review this for me?

            Show
            krughoff Simon Krughoff added a comment - Tim, can you review this for me?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Assuming no-one is actively using this code and that all the integration tests we have (including from Sims, Scott Daniel) pass, then it seems that this change has removed the code that needs to be removed.

            Show
            tjenness Tim Jenness added a comment - Assuming no-one is actively using this code and that all the integration tests we have (including from Sims, Scott Daniel ) pass, then it seems that this change has removed the code that needs to be removed.
            Hide
            Permalink
            danielsf Scott Daniel added a comment -

            There are tests in lsst_sims that exercise our dependence on obs_lsstSim so, if you can get lsst_sims to build, then you have done everything I/we need you to do.

            Show
            danielsf Scott Daniel added a comment - There are tests in lsst_sims that exercise our dependence on obs_lsstSim so, if you can get lsst_sims to build, then you have done everything I/we need you to do.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Merged.

            Show
            krughoff Simon Krughoff added a comment - Merged.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Tim Jenness
              Watchers:
              Fritz Mueller, Scott Daniel, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.