Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_algorithms
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:DRP S18-4
-
Team:Data Release Production
Description
ScienceSourceSelectorTask is slowly appending to a table when it can simply do the selection. The loop at https://github.com/lsst/meas_algorithms/blob/f7dca96402cda034104c615be7ef821ab3aa9ea9/python/lsst/meas/algorithms/sourceSelector.py#L451 is unnecessary.
Added into this ticket RequireIsolated to ScienceSourceSelectorTask to select isolated sources where ((catalog['parent'] == 0) & (catalog['deblend_nChild'] == 0)). There was some discussion on Slack between myself, John Parejko and Jim Bosch (https://lsstc.slack.com/archives/C2JPMCF5X/p1521218208000586 ) as to whether a loop over footprints was necessary, as discussed in DM-7100 and implemented in AstrometrySourceSelectorTask: https://github.com/lsst/meas_algorithms/blob/f7dca96402cda034104c615be7ef821ab3aa9ea9/python/lsst/meas/algorithms/astrometrySourceSelector.py#L107 .
However, it seems that this is redundant in the case that the deblender has been run, which is required in the case that the deblend_nChild field actually exists. Therefore, my implementation does not do this loop (saving time on both loading the catalog and looping over sources). I have made a note of this in the docstring that RequireIsolated can only be run on catalogs that have had the deblender run.