Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13846

Write unittest for GtransfoPoly(gtransfo) constructor

    XMLWordPrintable

    Details

      Description

      GtransfoPoly(gtransfo, frame, degree, nPoint) needs a unittest and should probably be refactored, though I think it's only used by the SimpleAstrometryModel. It came with a commented out #ifdef TO_BE_FIXED too.

        Attachments

          Issue Links

          mentioned in

          Page Loading...

            Activity

            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Reviewing old tickets for CCB: this still looks relevant, even though the classes involved have been renamed (GtransoPoly->AstrometryTransformPolynomial and gtransfo->AstrometryTransform), and this does seemed to be used by ConstrainedAstrometryModel (https://github.com/lsst/jointcal/blob/7f1c91f61beaa663a6ddc2696f0071bad96cbf6f/src/ConstrainedAstrometryModel.cc#L95-L97) as well as SimpleAstrometryModel. That makes this a bit more important (the constrained model is what we use in production), but it also means we've got pretty good indirect test coverage, so I still don't think this is a high priority.

            Show
            jbosch Jim Bosch added a comment - Reviewing old tickets for CCB: this still looks relevant, even though the classes involved have been renamed (GtransoPoly->AstrometryTransformPolynomial and gtransfo->AstrometryTransform), and this does seemed to be used by ConstrainedAstrometryModel ( https://github.com/lsst/jointcal/blob/7f1c91f61beaa663a6ddc2696f0071bad96cbf6f/src/ConstrainedAstrometryModel.cc#L95-L97 ) as well as SimpleAstrometryModel. That makes this a bit more important (the constrained model is what we use in production), but it also means we've got pretty good indirect test coverage, so I still don't think this is a high priority.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.