Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13881

Fix fallout in sky frame construction from detection API change

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
    • Team:
      External

      Description

      Masayuki Tanaka reports the following error, which is fallout from DM-13741:

      $ constructSky.py $ROOT --calib $CALIBROOT --rerun $RERUN --cores 1 --batch-type=smp --time 0.5  --job jobname--mpiexec="-prepend-rank" --id visit=6294^6296^6298
       
      sky.detection INFO: Detected 1129 positive peaks in 963 footprints and 10 negative peaks in 10 footprints to 5 sigma
      sky.detection INFO: Resubtracting the background after object detection
      AttributeError on hda-mds02:32335 in reduce: 'BackgroundList' object has no attribute 'getImageF'
      Traceback (most recent call last):
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/ctrl_pool/6.0-hsc/python/lsst/ctrl/pool/pool.py", line 113, in wrapper
          return func(*args, **kwargs)
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/ctrl_pool/6.0-hsc/python/lsst/ctrl/pool/pool.py", line 239, in wrapper
          return func(*args, **kwargs)
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/ctrl_pool/6.0-hsc/python/lsst/ctrl/pool/pool.py", line 715, in reduce
          *args, **kwargs)
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/ctrl_pool/6.0-hsc/python/lsst/ctrl/pool/pool.py", line 572, in _reduceQueue
          resultList = [func(self._getCache(context, i), data, *args, **kwargs) for i, data in queue]
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/ctrl_pool/6.0-hsc/python/lsst/ctrl/pool/pool.py", line 572, in <listcomp>
          resultList = [func(self._getCache(context, i), data, *args, **kwargs) for i, data in queue]
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/pipe_drivers/6.1-hsc/python/lsst/pipe/drivers/constructCalibs.py", line 1208, in measureBackground
          exposure = self.processSingleBackground(dataRef)
        File "/ana/products.6.1/stack/miniconda3-4.3.21-10a4fa6/Linux64/pipe_drivers/6.1-hsc/python/lsst/pipe/drivers/constructCalibs.py", line 1238, in processSingleBackground
          image += footprints.background.getImageF()
      AttributeError: 'BackgroundList' object has no attribute 'getImageF'
      application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
      

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            One-character change:

            price@pap-laptop-2:~/LSST/pipe_drivers (tickets/DM-13881=) $ git sub-patch
            commit d1379d508a5ce273ac1d471966e2a17fc7e0cec9 (HEAD -> tickets/DM-13881, origin/tickets/DM-13881)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Fri Mar 23 13:26:05 2018 -0400
             
                SkyTask: fix fallout from detection background API change
                
                The SourceDetectionTask's returned 'background' is now a BackgroundList
                instead of a BackgroundMI (RFC-463, DM-13741).
             
            diff --git a/python/lsst/pipe/drivers/constructCalibs.py b/python/lsst/pipe/drivers/constructCalibs.py
            index 5ba8a0c..1ca05fa 100644
            --- a/python/lsst/pipe/drivers/constructCalibs.py
            +++ b/python/lsst/pipe/drivers/constructCalibs.py
            @@ -1235,7 +1235,7 @@ class SkyTask(CalibTask):
                     footprints = self.detection.detectFootprints(exposure, sigma=self.config.detectSigma)
                     image = exposure.getMaskedImage()
                     if footprints.background is not None:
            -            image += footprints.background.getImageF()
            +            image += footprints.background.getImage()
             
                     # Mask high pixels
                     variance = image.getVariance()
            

            Show
            price Paul Price added a comment - One-character change: price@pap-laptop-2:~/LSST/pipe_drivers (tickets/DM-13881=) $ git sub-patch commit d1379d508a5ce273ac1d471966e2a17fc7e0cec9 (HEAD -> tickets/DM-13881, origin/tickets/DM-13881) Author: Paul Price <price@astro.princeton.edu> Date: Fri Mar 23 13:26:05 2018 -0400   SkyTask: fix fallout from detection background API change The SourceDetectionTask's returned 'background' is now a BackgroundList instead of a BackgroundMI (RFC-463, DM-13741).   diff --git a/python/lsst/pipe/drivers/constructCalibs.py b/python/lsst/pipe/drivers/constructCalibs.py index 5ba8a0c..1ca05fa 100644 --- a/python/lsst/pipe/drivers/constructCalibs.py +++ b/python/lsst/pipe/drivers/constructCalibs.py @@ -1235,7 +1235,7 @@ class SkyTask(CalibTask): footprints = self.detection.detectFootprints(exposure, sigma=self.config.detectSigma) image = exposure.getMaskedImage() if footprints.background is not None: - image += footprints.background.getImageF() + image += footprints.background.getImage() # Mask high pixels variance = image.getVariance()
            Hide
            jbosch Jim Bosch added a comment -

            Looks good!

            Show
            jbosch Jim Bosch added a comment - Looks good!
            Hide
            price Paul Price added a comment -

            Thanks Jim!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Jim! Merged to master.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Watchers:
              Jim Bosch, Masayuki Tanaka, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.