Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13888

Log message from DM-13803 is scary

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_persistence
    • Labels:
      None
    • Team:
      Architecture

      Description

      For certain bypass functions (e.g. `calexp_visitInfo`), searching through parent repositories is natural and expected. The resulting log messages inserted in DM-13803 at INFO level are unexpected and mention exceptions that make them look like errors.

      Reduce the logging level to DEBUG, and remove the exception names.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          A small change to code that isn't exercised in tests, so a Jenkins run ought to be meaningless.

          Show
          ktl Kian-Tat Lim added a comment - A small change to code that isn't exercised in tests, so a Jenkins run ought to be meaningless.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Approved, although I'd suggest a jenkins run anyway: this branch might be executed by tests further down the line (e.g. in jointcal).

          Show
          Parejkoj John Parejko added a comment - Approved, although I'd suggest a jenkins run anyway: this branch might be executed by tests further down the line (e.g. in jointcal).
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          And jenkins did fail: looks like my editor was one space off on the continuation line indentation

          Show
          ktl Kian-Tat Lim added a comment - And jenkins did fail: looks like my editor was one space off on the continuation line indentation
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Jenkins passed (on Centos7, Py3, so should work fine on the others); merged.

          Show
          ktl Kian-Tat Lim added a comment - Jenkins passed (on Centos7, Py3, so should work fine on the others); merged.
          Hide
          Permalink
          ctslater Colin Slater added a comment -

          Thanks John Parejko and Kian-Tat Lim for this. Hayden Smotherman and I both got caught by the scary not-really-an-error, and the fix looks much better.

          Show
          ctslater Colin Slater added a comment - Thanks John Parejko and Kian-Tat Lim for this. Hayden Smotherman and I both got caught by the scary not-really-an-error, and the fix looks much better.

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            John Parejko
            Watchers:
            Colin Slater, John Parejko, Kian-Tat Lim
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.