Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13898

Remove the XYTransform classes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      Implement RFC-470 by removing the lsst::afw::geom::XYTransform classes

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9216 Replace afw::geom::Functor with std::function

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11835 Audit the stack for uses of XYTransform which need replacing

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-470 Remove the XYTransform classes

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            A lot of deletions in afw, a few deletions in obs_lsstSim (the edge rolloff functor, which was designed for a SeparableXYTransform but was not being used) and some small changes to accommodate.

            I also enabled automatic flake8 testing in obs_lsstSim.

            Show
            rowen Russell Owen added a comment - - edited A lot of deletions in afw , a few deletions in obs_lsstSim (the edge rolloff functor, which was designed for a SeparableXYTransform but was not being used) and some small changes to accommodate. I also enabled automatic flake8 testing in obs_lsstSim .
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Successful Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27799/pipeline

            Show
            rowen Russell Owen added a comment - Successful Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27799/pipeline
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Everything looks ok to me, although I haven't used the relevant classes before. One thing I noticed is that you stripped out afw::geom::Functor, is that something that only existed for the XYTransform class? 

            Show
            fred3m Fred Moolekamp added a comment - Everything looks ok to me, although I haven't used the relevant classes before. One thing I noticed is that you stripped out afw::geom::Functor , is that something that only existed for the XYTransform class? 
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Functor was designed to supply the separable components to SeparableXYTransform. The only usage was the edge rolloff functor in obs_lsstSim.

            Show
            rowen Russell Owen added a comment - Functor was designed to supply the separable components to SeparableXYTransform . The only usage was the edge rolloff functor in obs_lsstSim.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.