Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13905

Change SpherePoint.getVector to return a sphgeom UnitVector3d

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      Implement RFC-466: change SpherePoint.getVector to return a sphgeom.UnitVector3d instead of a Vector3D. Similarly change the SpherePoint vector constructor to accept a sphgeom.UnitVector3d.

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-13790 Remove all use of the geom package

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-466 Change SpherePoint.getVector to return a sphgeom UnitVector3d

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This is proving to be a bit of a nuisance because sphgeom has no Eigen integration. It is true that {[sphgeom.Vector3d}} and UnitVector3d can do many things that we used to do using Eigen, but not everything. I think we should tread carefully. Further discussion on DM-13790.

            Show
            rowen Russell Owen added a comment - This is proving to be a bit of a nuisance because sphgeom has no Eigen integration. It is true that {[sphgeom.Vector3d}} and UnitVector3d can do many things that we used to do using Eigen, but not everything. I think we should tread carefully. Further discussion on DM-13790 .
            Hide
            Permalink
            rowen Russell Owen added a comment -

            After discussions with Jim Bosch I did the following:

            • Added a function lsst::afw::geom::asEigen(sphgeom::Vector2d) (which works for UnitVector3d as well).
            • Made SpherePoint implicitly convertible to sphgeom::LonLat and constructable from sphgeom::LonLat.

            This now feels like a good step towards eliminating use of the old geom package

            Show
            rowen Russell Owen added a comment - After discussions with Jim Bosch I did the following: Added a function lsst::afw::geom::asEigen(sphgeom::Vector2d) (which works for UnitVector3d as well). Made SpherePoint implicitly convertible to sphgeom::LonLat and constructable from sphgeom::LonLat. This now feels like a good step towards eliminating use of the old geom package
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good!  Just a few comments on the afw PR.

            Show
            jbosch Jim Bosch added a comment - Looks good!  Just a few comments on the afw PR.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.