Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13943

Deprecate VisitInfo.getExposureId()

    XMLWordPrintable

    Details

      Description

      exposureId in VisitInfo is not actually a visit-level value, but a ccd-specific value. This requires deprecating `getExposureId()` in visitInfo, so that we can remove it, and replacing any uses of that method with the replacement from DM-29955.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31706 Do Release 24.0.0 of Science Pipelines

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32138 Remove VisitInfo.exposureId

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29955 Add ExposureInfo id getter (replacement for VisitInfo.getExposureId())

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13944 add id to VisitInfo

          • Done
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-13738 Remove exposureId from visitInfo

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-459 Remove exposureId from VisitInfo and add visitId

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Epic Link DM-13942 [ 39720 ]
            Parejkoj John Parejko made changes -
            Summary Move exposureId from VisitInfo to ExposureIfno Move exposureId from VisitInfo to ExposureInfo
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-13738 [ DM-13738 ]
            Parejkoj John Parejko made changes -
            Link This issue is duplicated by DM-13738 [ DM-13738 ]
            Parejkoj John Parejko made changes -
            Urgent? off
            Labels SciencePipelines PairCoding SciencePipelines
            Parejkoj John Parejko made changes -
            Assignee John Parejko [ parejkoj ]
            Parejkoj John Parejko made changes -
            Labels PairCoding SciencePipelines PairCoding
            Team Alert Production [ 10300 ]
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Link This issue is triggered by RFC-459 [ RFC-459 ]
            Parejkoj John Parejko made changes -
            Description {{exposureId}} in {{VisitInfo}} is not actually a visit-level value, but a ccd-specific value. Move it out of {{VisitInfo}} and into {{ExposureInfo}}, so it lives in the correct place. {{exposureId}} in {{VisitInfo}} is not actually a visit-level value, but a ccd-specific value. Move it out of {{VisitInfo}} and into {{ExposureInfo}}, so it lives in the correct place.

            Note: this requires deprecating `getExposureId()` in visitInfo.
            sullivan Ian Sullivan made changes -
            Epic Link DM-13942 [ 39720 ] DM-27911 [ 442604 ]
            sullivan Ian Sullivan made changes -
            Sprint AP S21-4 (March) [ 1079 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked lower
            sullivan Ian Sullivan made changes -
            Story Points 4
            sullivan Ian Sullivan made changes -
            Sprint AP S21-4 (March) [ 1079 ] AP S21-5 (April) [ 1084 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked lower
            sullivan Ian Sullivan made changes -
            Epic Link DM-27911 [ 442604 ] DM-29209 [ 459201 ]
            sullivan Ian Sullivan made changes -
            Sprint AP S21-5 (April) [ 1084 ] AP S21-6 (May) [ 1088 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked lower
            Parejkoj John Parejko made changes -
            Summary Move exposureId from VisitInfo to ExposureInfo Deprecate VisitInfo.getExposureId()
            Description {{exposureId}} in {{VisitInfo}} is not actually a visit-level value, but a ccd-specific value. Move it out of {{VisitInfo}} and into {{ExposureInfo}}, so it lives in the correct place.

            Note: this requires deprecating `getExposureId()` in visitInfo.             		{{exposureId}} in {{VisitInfo}} is not actually a visit-level value, but a ccd-specific value. This requires deprecating `getExposureId()` in visitInfo, so that we can remove it, and replacing any uses of that method with the replacement from DM-29955.
            sullivan Ian Sullivan made changes -
            Sprint AP S21-6 (May) [ 1088 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-29955 [ DM-29955 ]
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            sullivan Ian Sullivan made changes -
            Epic Link DM-29209 [ 459201 ] DM-30431 [ 504819 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-13944 [ DM-13944 ]
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Sprint AP F21-3 (August) [ 1109 ]
            sullivan Ian Sullivan made changes -
            Labels PairCoding PairCoding ap-analysis
            sullivan Ian Sullivan made changes -
            Assignee John Parejko [ parejkoj ] Krzysztof Findeisen [ krzys ]
            sullivan Ian Sullivan made changes -
            Sprint AP F21-3 (August) [ 1109 ] AP F21-2 (July) [ 1102 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked lower
            sullivan Ian Sullivan made changes -
            Sprint AP F21-2 (July) [ 1102 ] AP F21-3 (August) [ 1109 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked higher
            sullivan Ian Sullivan made changes -
            Sprint AP F21-3 (August) [ 1109 ] AP F21-4 (September) [ 1113 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30431 [ 504819 ] DM-30514 [ 510188 ]
            krzys Krzysztof Findeisen made changes -
            Sprint AP F21-4 (September) [ 1113 ] AP F21-5 (October) [ 1119 ]
            krzys Krzysztof Findeisen made changes -
            Rank Ranked lower
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-13738 [ DM-13738 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            From DM with John Parejko:

            So, the deprecation replacement message would say if you want a full focal plane identifier, use visitInfo.id; if you want a detector level identifier, use exposureInfo.id.

            Show
            krzys Krzysztof Findeisen added a comment - From DM with John Parejko : So, the deprecation replacement message would say if you want a full focal plane identifier, use visitInfo.id; if you want a detector level identifier, use exposureInfo.id.
            sullivan Ian Sullivan made changes -
            Rank Ranked higher
            krzys Krzysztof Findeisen made changes -
            Link This issue blocks DM-31706 [ DM-31706 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue blocks DM-32138 [ DM-32138 ]
            krzys Krzysztof Findeisen made changes -
            Sprint AP F21-5 (October) [ 1119 ] AP F21-6 (November) [ 1124 ]
            krzys Krzysztof Findeisen made changes -
            Rank Ranked lower
            krzys Krzysztof Findeisen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Thanks for agreeing to review this, Spencer Nelson. As usual not all of the PRs were picked up by Jira:

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for agreeing to review this, Spencer Nelson . As usual not all of the PRs were picked up by Jira: geom#35 afw#614 obs_base#396 obs_test#87 obs_decam#207 ip_isr#202 pipe_tasks#598 cp_pipe#108 ap_association#140
            krzys Krzysztof Findeisen made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            Reviewers Spencer Nelson [ swnelson ]
            swnelson Spencer Nelson made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krzys Krzysztof Findeisen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            krzys Krzysztof Findeisen made changes -
            Sprint AP F21-6 (November) [ 1124 ] AP F21-5 (October) [ 1119 ]

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Spencer Nelson
              Watchers:
              Jim Bosch, John Parejko, Krzysztof Findeisen, Russell Owen, Spencer Nelson
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.