Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13965

Disable C++ compiler check for pure-python packages

    Details

    • Team:
      External

      Description

      Following DM-13910, it's now possible to disable the C++ compiler check in `scons`, allowing us to build pure-python packages without a conforming C++ compiler (e.g., running ci_hsc on cluster nodes). Activate this on the following packages:

      • ci_hsc
      • ci_ctio0m9
      • pipe_drivers
      • pipe_tasks

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          It turns out that ci_hsc and ctio_0m9 don't need any changes to get the benefits of DM-13910 because they don't use lsst.sconsUtils.BasicSConstruct.

          Show
          price Paul Price added a comment - It turns out that ci_hsc and ctio_0m9 don't need any changes to get the benefits of DM-13910 because they don't use lsst.sconsUtils.BasicSConstruct .
          Hide
          price Paul Price added a comment -

          price@pap-laptop-2:~/LSST/pipe_tasks (tickets/DM-13965=) $ git sub-patch
          commit b04939e9c68afb6f2e52ba02c2d58187f085c99d (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 12:30:05 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index 522e7a6c..aab02c28 100644
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,4 +1,4 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
           
          -scripts.BasicSConstruct("pipe_tasks")
          +scripts.BasicSConstruct("pipe_tasks", disableCc=True)
           
           
          price@pap-laptop-2:~/LSST/pipe_drivers (tickets/DM-13965=) $ git sub-patch
          commit d21ccf7fec97da7196ec552770adf567341190c3 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 12:29:27 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index f24a73f..9593bed 100644
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,3 +1,3 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
          -scripts.BasicSConstruct("pipe_drivers")
          +scripts.BasicSConstruct("pipe_drivers", disableCc=True)
          

          Show
          price Paul Price added a comment - price@pap-laptop-2:~/LSST/pipe_tasks (tickets/DM-13965=) $ git sub-patch commit b04939e9c68afb6f2e52ba02c2d58187f085c99d (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 12:30:05 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index 522e7a6c..aab02c28 100644 --- a/SConstruct +++ b/SConstruct @@ -1,4 +1,4 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("pipe_tasks") +scripts.BasicSConstruct("pipe_tasks", disableCc=True)     price@pap-laptop-2:~/LSST/pipe_drivers (tickets/DM-13965=) $ git sub-patch commit d21ccf7fec97da7196ec552770adf567341190c3 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 12:29:27 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index f24a73f..9593bed 100644 --- a/SConstruct +++ b/SConstruct @@ -1,3 +1,3 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("pipe_drivers") +scripts.BasicSConstruct("pipe_drivers", disableCc=True)
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          Please add on my behalf:

          • obs_auxTel
          • obs_comCam
          • obs_ctio0m9
          • cp_pipe

          and perhaps, on behalf of others, all other python-only obs_packages?

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Please add on my behalf: obs_auxTel obs_comCam obs_ctio0m9 cp_pipe and perhaps, on behalf of others, all other python-only obs_packages?
          Hide
          price Paul Price added a comment -

          Merlin Fisher-Levine: I'm happy to do "all other python-only obs_packages" if someone tells me which ones, specifically. I shouldn't have to go looking for them when I'm the one doing the favour.

          price@pap-laptop-2:~/LSST/obs_auxTel (tickets/DM-13965=) $ git sub-patch
          commit 9b49eca0cfab2b4804ee03dc7d06575f41d4ba41 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 13:12:46 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index d831a8e..9eb9033 100755
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,3 +1,3 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
          -scripts.BasicSConstruct("obs_auxTel")
          +scripts.BasicSConstruct("obs_auxTel", disableCc=True)
           
           
          price@pap-laptop-2:~/LSST/obs_comCam (tickets/DM-13965=) $ git sub-patch
          commit 7925d7fc2ac6e132ba60c74adcfdb9f469902671 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 13:14:48 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index f84d817..edb62fc 100755
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,3 +1,3 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
          -scripts.BasicSConstruct("obs_comCam")
          +scripts.BasicSConstruct("obs_comCam", disableCc=True)
           
           
          price@pap-laptop-2:~/LSST/obs_ctio0m9 (tickets/DM-13965=) $ git sub-patch
          commit 64ef0c8261cce086cdff6699c9beb5717edb6da8 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 13:16:02 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index adfe00c..a8283d5 100755
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,3 +1,3 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
          -scripts.BasicSConstruct("obs_ctio0m9")
          +scripts.BasicSConstruct("obs_ctio0m9", disableCc=True)
           
           
          price@pap-laptop-2:~/LSST/cp_pipe (tickets/DM-13965=) $ git sub-patch
          commit f72044f2b01e19e9dfd9f45b76a0ab4be4666599 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Mon Apr 2 13:20:36 2018 -0400
           
              scons: disable C++ compiler check
              
              Allows us to build without a conforming C++ compiler (because we don't
              need it).
           
          diff --git a/SConstruct b/SConstruct
          index 9695aba..208bfc6 100644
          --- a/SConstruct
          +++ b/SConstruct
          @@ -1,3 +1,3 @@
           # -*- python -*-
           from lsst.sconsUtils import scripts
          -scripts.BasicSConstruct("cp_pipe")
          +scripts.BasicSConstruct("cp_pipe", disableCc=True)
          

          Show
          price Paul Price added a comment - Merlin Fisher-Levine : I'm happy to do "all other python-only obs_packages" if someone tells me which ones, specifically. I shouldn't have to go looking for them when I'm the one doing the favour. price@pap-laptop-2:~/LSST/obs_auxTel (tickets/DM-13965=) $ git sub-patch commit 9b49eca0cfab2b4804ee03dc7d06575f41d4ba41 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 13:12:46 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index d831a8e..9eb9033 100755 --- a/SConstruct +++ b/SConstruct @@ -1,3 +1,3 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("obs_auxTel") +scripts.BasicSConstruct("obs_auxTel", disableCc=True)     price@pap-laptop-2:~/LSST/obs_comCam (tickets/DM-13965=) $ git sub-patch commit 7925d7fc2ac6e132ba60c74adcfdb9f469902671 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 13:14:48 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index f84d817..edb62fc 100755 --- a/SConstruct +++ b/SConstruct @@ -1,3 +1,3 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("obs_comCam") +scripts.BasicSConstruct("obs_comCam", disableCc=True)     price@pap-laptop-2:~/LSST/obs_ctio0m9 (tickets/DM-13965=) $ git sub-patch commit 64ef0c8261cce086cdff6699c9beb5717edb6da8 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 13:16:02 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index adfe00c..a8283d5 100755 --- a/SConstruct +++ b/SConstruct @@ -1,3 +1,3 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("obs_ctio0m9") +scripts.BasicSConstruct("obs_ctio0m9", disableCc=True)     price@pap-laptop-2:~/LSST/cp_pipe (tickets/DM-13965=) $ git sub-patch commit f72044f2b01e19e9dfd9f45b76a0ab4be4666599 (HEAD -> tickets/DM-13965, origin/tickets/DM-13965) Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 2 13:20:36 2018 -0400   scons: disable C++ compiler check Allows us to build without a conforming C++ compiler (because we don't need it).   diff --git a/SConstruct b/SConstruct index 9695aba..208bfc6 100644 --- a/SConstruct +++ b/SConstruct @@ -1,3 +1,3 @@ # -*- python -*- from lsst.sconsUtils import scripts -scripts.BasicSConstruct("cp_pipe") +scripts.BasicSConstruct("cp_pipe", disableCc=True)
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          Oh, I agree 100%. That comment was put in the hope that other people who know which ones are would chime in after I named the ones that I know about

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Oh, I agree 100%. That comment was put in the hope that other people who know which ones are would chime in after I named the ones that I know about
          Hide
          price Paul Price added a comment -

          Well, at least it's simple enough for people to do if they decide later they want it.

          Merlin Fisher-Levine, would you mind signing off on the ones I've already done?

          Jenkins is about done, and 3/4 are green.

          Show
          price Paul Price added a comment - Well, at least it's simple enough for people to do if they decide later they want it. Merlin Fisher-Levine , would you mind signing off on the ones I've already done? Jenkins is about done, and 3/4 are green.
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          That looks good to me 

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - That looks good to me 
          Hide
          price Paul Price added a comment -

          Thanks Merlin.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Merlin. Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Merlin Fisher-Levine
              Watchers:
              Merlin Fisher-Levine, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel