Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13975

IngestCalibsTask does not use --calibType consistently

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:

      Description

      IngestCalibsTask takes a --calibType command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if --calibType is provided, CalibsParseTask.getDestination will try to auto-detect the calib type, causing inconsistent behavior or crashing.

      Because CalibsParseTask.getDestination overrides ParseTask.getDestination, and is itself overridden in many obs packages, changing the API of getDestination is rather risky. However, I don't see another way to pass a manually provided file type to getDestination. Perhaps CalibsParseTask.getDestination could be given an optional calibType parameter that defaults to the old behavior.

        Attachments

          Issue Links

            Activity

            Hide
            ctslater Colin Slater added a comment -

            obs_decam uses this for ingesting defects, as described in the package README. I do not know what happens if one tries it without specifying calibType.

            Show
            ctslater Colin Slater added a comment - obs_decam uses this for ingesting defects, as described in the package README. I do not know what happens if one tries it without specifying calibType.
            Hide
            tjenness Tim Jenness added a comment -

            This code is no longer used and will be deleted in DM-35670.

            Show
            tjenness Tim Jenness added a comment - This code is no longer used and will be deleted in DM-35670 .

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              krzys Krzysztof Findeisen
              Watchers:
              Colin Slater, John Swinbank, Krzysztof Findeisen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.