Details
-
Type:
Bug
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:
-
Story Points:2
-
Epic Link:
-
Team:Alert Production
Description
IngestCalibsTask takes a --calibType command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if --calibType is provided, CalibsParseTask.getDestination will try to auto-detect the calib type, causing inconsistent behavior or crashing.
Because CalibsParseTask.getDestination overrides ParseTask.getDestination, and is itself overridden in many obs packages, changing the API of getDestination is rather risky. However, I don't see another way to pass a manually provided file type to getDestination. Perhaps CalibsParseTask.getDestination could be given an optional calibType parameter that defaults to the old behavior.
Attachments
Issue Links
Activity
Krzysztof Findeisen
created issue -
Krzysztof Findeisen
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Description |
{{IngestCalibsTask}} takes a {{--calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{--calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.
Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior. |
{{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.
Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior. |
Krzysztof Findeisen
made changes -
| Description |
{{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.
Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior. |
{{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.
Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional {{calibType}} parameter that defaults to the old behavior. |
| Epic Link |
|
| Team | Alert Production [ 10300 ] |
Krzysztof Findeisen
made changes -
Nikolina Horvat
made changes -
Krzysztof Findeisen
made changes -
| Labels | gen2-only |
This code is no longer used and will be deleted in DM-35670.
| Resolution | Done [ 10000 ] | |
| Status | To Do [ 10001 ] | Won't Fix [ 10405 ] |
obs_decam uses this for ingesting defects, as described in the package README. I do not know what happens if one tries it without specifying calibType.