Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13975

IngestCalibsTask does not use --calibType consistently

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:

      Description

      IngestCalibsTask takes a --calibType command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if --calibType is provided, CalibsParseTask.getDestination will try to auto-detect the calib type, causing inconsistent behavior or crashing.

      Because CalibsParseTask.getDestination overrides ParseTask.getDestination, and is itself overridden in many obs packages, changing the API of getDestination is rather risky. However, I don't see another way to pass a manually provided file type to getDestination. Perhaps CalibsParseTask.getDestination could be given an optional calibType parameter that defaults to the old behavior.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-14866 decam defect ingest silently retrieves calibDate from file path

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5467 Distribute bad pixel masks in obs_decam

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            krzys Krzysztof Findeisen created issue -
            krzys Krzysztof Findeisen made changes -
            Field Original Value New Value
            Description {{IngestCalibsTask}} takes a {{--calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{--calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.

            Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior.             		{{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.

            Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior.
            krzys Krzysztof Findeisen made changes -
            Description {{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.

            Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional parameter that defaults to the old behavior.             		{{IngestCalibsTask}} takes a {{\-\-calibType}} command-line argument that lets the user specify the type of file instead of letting the computer auto-detect it. However, even if {{\-\-calibType}} is provided, {{CalibsParseTask.getDestination}} will try to auto-detect the calib type, causing inconsistent behavior or crashing.

            Because {{CalibsParseTask.getDestination}} overrides {{ParseTask.getDestination}}, and is itself overridden in many {{obs}} packages, changing the API of {{getDestination}} is rather risky. However, I don't see another way to pass a manually provided file type to {{getDestination}}. Perhaps {{CalibsParseTask.getDestination}} could be given an optional {{calibType}} parameter that defaults to the old behavior.
            swinbank John Swinbank made changes -
            Epic Link DM-12728 [ 36327 ]
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ]
            swinbank John Swinbank made changes -
            Epic Link DM-12728 [ 36327 ] DM-14447 [ 80385 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-5467 [ DM-5467 ]
            mrawls Meredith Rawls made changes -
            Link This issue relates to DM-14866 [ DM-14866 ]
            swinbank John Swinbank made changes -
            Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
            swinbank John Swinbank made changes -
            Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
            swinbank John Swinbank made changes -
            Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
            swinbank John Swinbank made changes -
            Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
            swinbank John Swinbank made changes -
            Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
            swinbank John Swinbank made changes -
            Epic Link DM-24339 [ 433026 ] DM-25139 [ 435257 ]
            swinbank John Swinbank made changes -
            Epic Link DM-25139 [ 435257 ] DM-26810 [ 439762 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-26810 [ 439762 ] DM-27906 [ 442554 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-27906 [ 442554 ] DM-29214 [ 459218 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-29214 [ 459218 ] DM-30436 [ 504824 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30436 [ 504824 ] DM-30501 [ 510159 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30501 [ 510159 ] DM-30502 [ 510160 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30502 [ 510160 ] DM-30506 [ 510172 ]
            horvat Nikolina Horvat made changes -
            Epic Link DM-30506 [ 510172 ] DM-34931 [ 1598492 ]
            krzys Krzysztof Findeisen made changes -
            Labels gen2-only
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Won't Fix [ 10405 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              krzys Krzysztof Findeisen
              Watchers:
              Colin Slater, John Swinbank, Krzysztof Findeisen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.