Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: jointcal
-
Labels:
-
Story Points:2
-
Epic Link:
-
Team:Alert Production
Description
jointcal's Gtransfo object (a mutable 2->2 transform designed for astrometry and optimized for being fit) should have a name that better matches our standards. I created PhotometryTransform, so I suppose an appropriate new name might be AstrometryTransform?
Attachments
Issue Links
Activity
Paul Price: In the interest of letting no good deed go unpunished, would you be willing to review this massive changeset (that you'd originally requested)? You can choose how to handle the review: I'm not sure it's worth your looking at every line, given that it's roughly +/-1400 lines (more + than - because of reflowing lines that became longer), but I don't know how else to do it.
I tried to be as thorough as I could be, using a few regexes at the end to catch the remaining transfo* cases, so I don't think I missed any.
Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29081/pipeline
If this is solely a rename and it passes Jenkins, then I'm going to suggest it simply be merged without review.
Paul Price
added a comment - If this is solely a rename and it passes Jenkins, then I'm going to suggest it simply be merged without review. In that case, are you at least happy with the commit messages?
The first one appears to mix features (renames, fix include guard, cleanup docstrings), but I could believe they are difficult to disentangle from such a wide-ranging change.
Paul Price
added a comment - The first one appears to mix features (renames, fix include guard, cleanup docstrings), but I could believe they are difficult to disentangle from such a wide-ranging change. The include guard fixes were because of the rename (to keep them in sync), as were most of the docstring cleanups.
New names now merged.
I'll do this as soon as
DM-13270is merged.