Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13976

Rename jointcal.gtransfo

    XMLWordPrintable

    Details

      Description

      jointcal's Gtransfo object (a mutable 2->2 transform designed for astrometry and optimized for being fit) should have a name that better matches our standards. I created PhotometryTransform, so I suppose an appropriate new name might be AstrometryTransform?

        Attachments

          Issue Links

          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13270 cherry pick ccdImage method cleanups from DM-9071

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13272 Confirm jointcal's astrometry output

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to DM-13272 [ DM-13272 ]
            Parejkoj John Parejko made changes -
            Link This issue has to be done after DM-13270 [ DM-13270 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I'll do this as soon as DM-13270 is merged.

            Show
            Parejkoj John Parejko added a comment - I'll do this as soon as DM-13270 is merged.
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Paul Price: In the interest of letting no good deed go unpunished, would you be willing to review this massive changeset (that you'd originally requested)? You can choose how to handle the review: I'm not sure it's worth your looking at every line, given that it's roughly +/-1400 lines (more + than - because of reflowing lines that became longer), but I don't know how else to do it.

            I tried to be as thorough as I could be, using a few regexes at the end to catch the remaining transfo* cases, so I don't think I missed any.

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29081/pipeline

            Show
            Parejkoj John Parejko added a comment - Paul Price : In the interest of letting no good deed go unpunished, would you be willing to review this massive changeset (that you'd originally requested)? You can choose how to handle the review: I'm not sure it's worth your looking at every line, given that it's roughly +/-1400 lines (more + than - because of reflowing lines that became longer), but I don't know how else to do it. I tried to be as thorough as I could be, using a few regexes at the end to catch the remaining transfo* cases, so I don't think I missed any. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29081/pipeline
            Parejkoj John Parejko made changes -
            Reviewers Paul Price [ price ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            price Paul Price added a comment -

            If this is solely a rename and it passes Jenkins, then I'm going to suggest it simply be merged without review.

            Show
            price Paul Price added a comment - If this is solely a rename and it passes Jenkins, then I'm going to suggest it simply be merged without review.
            price Paul Price made changes -
            Assignee John Parejko [ parejkoj ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            In that case, are you at least happy with the commit messages?

            Show
            Parejkoj John Parejko added a comment - In that case, are you at least happy with the commit messages?
            Hide
            Permalink
            price Paul Price added a comment -

            The first one appears to mix features (renames, fix include guard, cleanup docstrings), but I could believe they are difficult to disentangle from such a wide-ranging change.

            Show
            price Paul Price added a comment - The first one appears to mix features (renames, fix include guard, cleanup docstrings), but I could believe they are difficult to disentangle from such a wide-ranging change.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            The include guard fixes were because of the rename (to keep them in sync), as were most of the docstring cleanups.

            Show
            Parejkoj John Parejko added a comment - The include guard fixes were because of the rename (to keep them in sync), as were most of the docstring cleanups.
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            New names now merged.

            Show
            Parejkoj John Parejko added a comment - New names now merged.
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16722 [ 235355 ]
            swinbank John Swinbank made changes -
            Watchers John Parejko, John Swinbank, Paul Price, Pim Schellart [X] [ John Parejko, John Swinbank, Paul Price, Pim Schellart [X] ] John Parejko, John Swinbank, Paul Price [ John Parejko, John Swinbank, Paul Price ]
            swinbank John Swinbank made changes -
            Epic Link DM-16722 [ 235355 ] DM-16742 [ 235428 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Paul Price
              Watchers:
              John Parejko, John Swinbank, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.