Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14007

Fix py2 linter error in skymap

    XMLWordPrintable

    Details

      Description

      Fix the following python 2 error:

      /home/jenkins-slave/workspace/stack-os-matrix/centos-7.py2/lsstsw/build/skymap/examples/plotSkyMap.py:189:69: F812 list comprehension redefines 'x' from line 180 /home/jenkins-slave/workspace/stack-os-matrix/centos-7.py2/lsstsw/build/skymap/examples/plotSkyMap.py:189:72: F812 list comprehension redefines 'y' from line 180

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-13998 Enable automatic flake8 testing in skymap

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            The fix is trivial, but I don't understand how DM-13998 passed Travis on github and then failed on Jenkins for the same issue. Travis caught an earlier example of the same python-2-only error in the same file. But when I fixed that it passed. Since the file was a Python file in examples (and thus never executed by Jenkins) and it passed Travis's pep8 tests and scons's own pep8 tests passed on my machine, I thought it was safe to merge.

            Show
            rowen Russell Owen added a comment - - edited The fix is trivial, but I don't understand how DM-13998 passed Travis on github and then failed on Jenkins for the same issue. Travis caught an earlier example of the same python-2-only error in the same file. But when I fixed that it passed. Since the file was a Python file in examples (and thus never executed by Jenkins) and it passed Travis's pep8 tests and scons's own pep8 tests passed on my machine, I thought it was safe to merge.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            The travis script is only running python3 flake8. There is no python2 check.

            Show
            tjenness Tim Jenness added a comment - The travis script is only running python3 flake8. There is no python2 check.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Fix looks fine to me.

            Show
            ktl Kian-Tat Lim added a comment - Fix looks fine to me.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Jenkins run 27768 made it past skymap so I merged.

            Show
            rowen Russell Owen added a comment - Jenkins run 27768 made it past skymap so I merged.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Watchers:
              Kian-Tat Lim, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.