Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14066

Make dynamic detection more robust

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Team:
      External

      Description

      Entire images are being poisoned by a single NAN that came out of the forced measurement in dynamic detection. It needs to be robust against bad measurements.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          price Paul Price added a comment -

          Hsin-Fang Chiang, since you were poking around here last night, would you mind having another look?

          pprice@tiger-sumire:~/LSST/meas/algorithms (tickets/DM-14066=) $ git sub
          		 
          commit a09d3665faf316fbe2c01523ddfb6071a7c18dcc
          		 
          Author: Paul Price <price@astro.princeton.edu>
          		 
          Date:   Wed Apr 11 12:31:04 2018 -0400
          		 
           
          		 
              make dynamic detection more robust
          		 
              
              The last patch added a check of the flags; now actually use them, and
          		 
              check for non-finite values for good measure. If a single NAN gets into
          		 
              the background calculation, it can poison the entire image.
          		 
           
          		 
           python/lsst/meas/algorithms/dynamicDetection.py | 8 ++++----
          		 
           1 file changed, 4 insertions(+), 4 deletions(-)

          Show
          price Paul Price added a comment - Hsin-Fang Chiang , since you were poking around here last night, would you mind having another look? pprice@tiger-sumire:~/LSST/meas/algorithms (tickets/DM-14066=) $ git sub commit a09d3665faf316fbe2c01523ddfb6071a7c18dcc Author: Paul Price <price@astro.princeton.edu> Date: Wed Apr 11 12:31:04 2018 -0400   make dynamic detection more robust The last patch added a check of the flags; now actually use them, and check for non-finite values for good measure. If a single NAN gets into the background calculation, it can poison the entire image.   python/lsst/meas/algorithms/dynamicDetection.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
          Hide
          Permalink
          hchiang2 Hsin-Fang Chiang added a comment -

          LGTM

          Show
          hchiang2 Hsin-Fang Chiang added a comment - LGTM
          Hide
          Permalink
          price Paul Price added a comment -

          Jenkins is green.

          Show
          price Paul Price added a comment - Jenkins is green.
          Hide
          Permalink
          price Paul Price added a comment -

          Thanks Hsin-Fang Chiang!

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Hsin-Fang Chiang ! Merged to master.

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Hsin-Fang Chiang
            Watchers:
            Hsin-Fang Chiang, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.