A git-bisect example script might be proposed in a future ticket:

For example:

killall mysqld mysql-proxy xrootd java python

setup -k -r . &&

rm -rf build lib proxy bin cfg  &&

eupspkg -e PREFIX=$PWD install &&

qserv-configure.py --all --force &&

~/qserv-run/2014_10.0/bin/qserv-start.sh &&

qserv-test-integration.py &&

~/qserv-run/2014_10.0/bin/qserv-stop.sh

Hi Fabrice,

did you push anything into origin for review, or what am I supposed to review?

Andy

Hi Andy,

Sorry for not specifying the repository to review. Ticket branch is here https://dev.lsstcorp.org/cgit/LSST/DMS/testdata/qserv_testdata.git/.

Cheers,

Fabrice

My bad, I forgot we have second repository which also has scripts now. Friday afternoon, my brains are not functioning well I'll try to review it today.

It's small change and looks OK, couple of comments:

• would it make sense to do the same for other test scripts (qserv-check-integration.py, qserv-testunit.py)?
• I'm a bit worried about calling sys.exit() with boolean expression as an argument. Python bool is a subclass of int but sys.exit() documentation does not say anything about subclasses, it only mentions int. Being paranoid I'd add explicit conversion to int: sys.exit(int(expression)).

Thanks Andy,

• yes, it makes sense.
• ok, I'll do it, what a pity python isn't a bit more typed.