Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14099

Update minimum required git-lfs client version in docs

    XMLWordPrintable

    Details

      Description

      v1.1.0 currently cited in https://developer.lsst.io/git/git-lfs.html?highlight=lfs#installing-git-lfs is definitely too old. We have user reports of our Git LFS no longer working with older clients. lsstsw is installing v2.3.4. Joshua Hoblitt things v1.5.5 might be ok. Yusra AlSayyad reports that 1.7 doesn’t work.

      Pages to update:

        Attachments

          Activity

          Hide
          yusra Yusra AlSayyad added a comment -

          I don't think I'm reporting that 1.7 doesn't work, because it looks like it was the version in my lsstsw/bin/ that was being used. Here's a little more detail on what happened. I was trying to git pull ci_hsc and rerun lsstsw.

          On lsstsw, it was asking me for a username

                        pyfits:  ok (0.3 sec).
                  python_d2to1:  ok (0.4 sec).
               stsci_distutils:  ok (0.3 sec).
                          geom:  ok (0.3 sec).
            testdata_deblender: Username for 'https://s3.amazonaws.com':
          

          So on lsstsw, I git pulled, reran bin/deploy. Still was prompted for a username. Then I swapped the git-lfs that was in my lsstsw (lsstsw/lfs/bin):

          Yusras-MBP:bin yusra$ ./git-lfs-old version
          git-lfs/1.5.5 (GitHub; darwin amd64; go 1.7.4; git c2dcd6f5)
           

          out for the one I just upgraded via homebrew:

          Yusras-MBP:bin yusra$ ./git-lfs version
          git-lfs/2.4.0 (GitHub; darwin amd64; go 1.10)
          

          And now it doesn't prompt me for a username and I am happy.

          As for ci_hsc, here's the log:
          20180413T130744.219132507.log

          Show
          yusra Yusra AlSayyad added a comment - I don't think I'm reporting that 1.7 doesn't work, because it looks like it was the version in my lsstsw/bin/ that was being used. Here's a little more detail on what happened. I was trying to git pull ci_hsc and rerun lsstsw. On lsstsw, it was asking me for a username pyfits: ok (0.3 sec). python_d2to1: ok (0.4 sec). stsci_distutils: ok (0.3 sec). geom: ok (0.3 sec). testdata_deblender: Username for 'https://s3.amazonaws.com': So on lsstsw, I git pulled, reran bin/deploy. Still was prompted for a username. Then I swapped the git-lfs that was in my lsstsw (lsstsw/lfs/bin): Yusras-MBP:bin yusra$ ./git-lfs-old version git-lfs/1.5.5 (GitHub; darwin amd64; go 1.7.4; git c2dcd6f5) out for the one I just upgraded via homebrew: Yusras-MBP:bin yusra$ ./git-lfs version git-lfs/2.4.0 (GitHub; darwin amd64; go 1.10) And now it doesn't prompt me for a username and I am happy. As for ci_hsc, here's the log: 20180413T130744.219132507.log
          Hide
          jsick Jonathan Sick added a comment -

          We've decided to state git-lfs version 2.3.4 or later, since 2.3.4 is what's deployed by lsstsw: https://github.com/lsst/lsstsw/blob/master/bin/deploy#L17

          I think we're still not entirely clear why this change came about since our own Git LFS server infrastructure didn't change. It may also be a Mac-specific issue.

          Show
          jsick Jonathan Sick added a comment - We've decided to state git-lfs version 2.3.4 or later, since 2.3.4 is what's deployed by lsstsw: https://github.com/lsst/lsstsw/blob/master/bin/deploy#L17 I think we're still not entirely clear why this change came about since our own Git LFS server infrastructure didn't change. It may also be a Mac-specific issue.

            People

            Assignee:
            jsick Jonathan Sick
            Reporter:
            jsick Jonathan Sick
            Watchers:
            Jonathan Sick, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.