Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14153

Add warn messages for too few meas/ref sources per ccd

    XMLWordPrintable

    Details

      Description

      After every outer outlier rejection loop, we should check the number of reference and measured sources per ccd, and issue a warning if they get too small (where "small" is defined by a config parameter).

        Attachments

          Issue Links

          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14155 Experiment with other source selectors for photometry

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-14287 jointcal now depends on obs_cfht

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6354 Warn/raise when input catalogs have no (few?) cross-matches

          • Won't Fix

          Improvement - An improvement or enhancement to an existing feature or task. DM-13670 Check residual vs. errors for photometry

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Can you please review this small cleanup (first commit) and addition (second commit) to jointcal? You should be able to look at the commits separately.

            Show
            Parejkoj John Parejko added a comment - Can you please review this small cleanup (first commit) and addition (second commit) to jointcal? You should be able to look at the commits separately.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Russell Owen: I've updated the PR based on your comments (in particular, adding tests for countStars, which entailed writing some code to make fake catalogs). Can you please take another look at it?

            I haven't fully rebased the new commits, so you can look at them independently of the original code (starting with the "SQUASHME post review" commit). There's also a PR on testdata_jointcal, but that's just deleting a directory (which got moved to jointcal/tests/data).

            Show
            Parejkoj John Parejko added a comment - Russell Owen : I've updated the PR based on your comments (in particular, adding tests for countStars, which entailed writing some code to make fake catalogs). Can you please take another look at it? I haven't fully rebased the new commits, so you can look at them independently of the original code (starting with the "SQUASHME post review" commit). There's also a PR on testdata_jointcal , but that's just deleting a directory (which got moved to jointcal/tests/data ).
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27871/pipeline

            Show
            Parejkoj John Parejko added a comment - New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27871/pipeline
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Looks nice! A few small suggestions on github

            Show
            rowen Russell Owen added a comment - Looks nice! A few small suggestions on github
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for both reviews. I think I'm going to be happy I added testUtils in the future.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for both reviews. I think I'm going to be happy I added testUtils in the future. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.