Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14155

Experiment with other source selectors for photometry

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      AP S18-6

      Description

      The photometry failures may be related to not having"appropriate" reference stars. I should try a few other source selectors, starting with the flaggedStarSelector (which uses bright PSF sources), to see if they are a better match than the astrometrySourceSelector.

      I'll want to be able to count measuredStars (i.e. DM-14153) in order to tell whether the new source selector is picking enough sources to be useful.

        Attachments

          Issue Links

          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14153 Add warn messages for too few meas/ref sources per ccd

          • Done
          is blocked by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-9832 Cleanup and unify star selector call signatures

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14439 Explore numeric difference in Mac/Linux ConstrainedPhotometry fitting

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I managed to get this to work with the currently active DM-9832 branch. Unfortunately, it didn't help with the photometry fitting in validation_data_hsc.

            Show
            Parejkoj John Parejko added a comment - I managed to get this to work with the currently active DM-9832 branch. Unfortunately, it didn't help with the photometry fitting in validation_data_hsc.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run with DM-9832: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27947/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run with DM-9832 : https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27947/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Tim Morton [X]: do you mind reviewing this small change to jointcal that enables it to work with other source selectors?

            Using flaggedSourceSelector didn't solve the problem we were hoping it would, but it will enable future debugging.

            Note that I have to merge it simultaneously with DM-9832, which is going into review shortly.

            Show
            Parejkoj John Parejko added a comment - Tim Morton [X] : do you mind reviewing this small change to jointcal that enables it to work with other source selectors? Using flaggedSourceSelector didn't solve the problem we were hoping it would, but it will enable future debugging. Note that I have to merge it simultaneously with DM-9832 , which is going into review shortly.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Ian Sullivan: Tim told me he wasn't available to review. Would you be able to review this? It's small: a few code changes, plus three new tests, two of which are being skipped because of a Linux/mac difference that's not germane to this particular work.

            Show
            Parejkoj John Parejko added a comment - Ian Sullivan : Tim told me he wasn't available to review. Would you be able to review this? It's small: a few code changes, plus three new tests, two of which are being skipped because of a Linux/mac difference that's not germane to this particular work.
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            I added a few minor review comments on GitHub, but the changes look good overall.

            Show
            sullivan Ian Sullivan added a comment - I added a few minor review comments on GitHub, but the changes look good overall.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review.

            Merged along with DM-9832 and DM-10797, and done!

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review. Merged along with DM-9832 and DM-10797 , and done!

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Ian Sullivan
              Watchers:
              Dominique Boutigny, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Pierre Astier, Tim Morton [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.