Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14198

Modernize python in afw

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      0.25
    • Epic Link:
    • Sprint:
      AP S18-5
    • Team:
      Alert Production

      Description

      Modernize usage of ndarray in afw pybind11 wrappers, to eliminate a source of compiler warnings and future incompatibility

      Remove python 2 compatibility code

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Most of this is trivial and mechanical and needs only a casual glance. There is one usage of importing str from the future package as futurestring that is nontrivial but I believe it is correct. Also a cast in citizen I'm not positive about – but that's existing code and I was afraid to touch it, other than changing future's long to standard int.

          Jenkins passes.

          Show
          rowen Russell Owen added a comment - Most of this is trivial and mechanical and needs only a casual glance. There is one usage of importing str from the future package as futurestring that is nontrivial but I believe it is correct. Also a cast in citizen I'm not positive about – but that's existing code and I was afraid to touch it, other than changing future's long to standard int . Jenkins passes.
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Looks good to me. Couple of minor comments on the PR.

          Show
          tjenness Tim Jenness added a comment - Looks good to me. Couple of minor comments on the PR.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tim Jenness
            Watchers:
            Nate Lust, Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.