Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: SUIT
-
Labels:None
-
Story Points:6
-
Epic Link:
-
Sprint:SUIT Sprint 2018-04, SUIT Sprint 2018-05
-
Team:Science User Interface
Description
Loading table from the first extension of the attached src.fits fails.
catalina.out:
Caused by: java.lang.NullPointerException
|
at edu.caltech.ipac.firefly.server.util.ipactable.DataGroupWriter$IpacTableHandler.<init>(DataGroupWriter.java:145)
|
at edu.caltech.ipac.firefly.server.util.ipactable.DataGroupWriter.write(DataGroupWriter.java:29)
|
at edu.caltech.ipac.firefly.server.query.IpacTablePartProcessor.convertToIpacTable(IpacTablePartProcessor.java:102)
|
at edu.caltech.ipac.firefly.server.query.UserCatalogQuery.loadDataFile(UserCatalogQuery.java:65)
|
at edu.caltech.ipac.firefly.server.query.EmbeddedDbProcessorWrapper.ingestDataIntoDb(EmbeddedDbProcessorWrapper.java:46)
|
at edu.caltech.ipac.firefly.server.query.EmbeddedDbProcessor.populateDataTable(EmbeddedDbProcessor.java:185)
|
from firefly.log:
unable to get table from fits file /hydra/workarea/firefly/visualize/fits-cache/upload_7957750132203459808.fits, reason: card not legal
|
from firefly.out:
Apr 26, 2018 1:08:04 PM uk.ac.starlink.table.StarTableFactory makeStarTables
|
INFO: Table not FITS-plus - Doesn't look like a FITS-plus file
|
Apr 26, 2018 1:08:04 PM uk.ac.starlink.table.StarTableFactory makeStarTables
|
INFO: Table not colfits-plus - Doesn't look like a colfits-plus file
|
Apr 26, 2018 1:08:04 PM uk.ac.starlink.table.StarTableFactory makeStarTables
|
INFO: Table not colfits-basic - Doesn't have exactly one row
|
Attachments
Activity
Here are the updates made to Firefly and firefly_client per Firefly internal discussion,
For Firefly server, if a table is searched from the file with multiple tables (fits or votable),
the table index for a fits file is set to be 1 in case it is less than 1 or not found in the search query, or the table index for a votable is set to be 0 in case it is not found in the search query.
For firefly_client:
'table_index' parameter which takes one single number (extension number for fits or table index for votable) is added into API show_table & fetch_table for showing or fetching a table from a file containing multiple tables.
firefly_client PR is https://github.com/Caltech-IPAC/firefly_client/pull/22/
David Shupe
added a comment - firefly_client PR is https://github.com/Caltech-IPAC/firefly_client/pull/22/ The PR has been reviewed and approved on Github, with a number of small comments on docstrings and on the example notebook. The updated firefly_client will allow users to specify an extension other than "the first table" for both FITS and VOTable files.
David Shupe
added a comment - - edited The PR has been reviewed and approved on Github, with a number of small comments on docstrings and on the example notebook. The updated firefly_client will allow users to specify an extension other than "the first table" for both FITS and VOTable files. The show_table method will be revamped in DM-14352. We might take up the issue of allowing a list of extensions there.
David Shupe
added a comment - The show_table method will be revamped in DM-14352 . We might take up the issue of allowing a list of extensions there.
Is it reasonable to think about allowing table_index to be a list of extensions?