# Remove secondMomentStarSelector

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
0.5
• Sprint:
AP S18-5
• Team:

## Description

Remove secondMomentStarselector, per RFC-475, and clean up any tests, etc. that refer to it.

## Activity

Hide
John Parejko added a comment -

Yusra AlSayyad: do you mind reviewing this deletion ticket? Besides deleting the file, there were a handful of test changes to cleanup afterward.

Show
John Parejko added a comment - Yusra AlSayyad : do you mind reviewing this deletion ticket? Besides deleting the file, there were a handful of test changes to cleanup afterward.
Hide
John Parejko added a comment -
Show
John Parejko added a comment - Oh, and here's the official jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27873/pipeline
Hide

Looks good.

I wouldn't be surprised if this example doesn't run anymore, but would you double check what's going on here is still a good idea: https://github.com/lsst/pipe_tasks/blob/master/examples/measurePsfTask.py#L77

Show
Yusra AlSayyad added a comment - Looks good. I wouldn't be surprised if this example doesn't run anymore, but would you double check what's going on here is still a good idea: https://github.com/lsst/pipe_tasks/blob/master/examples/measurePsfTask.py#L77
Hide
John Parejko added a comment -

secondMomentSS does have this line in _PsfShapeHistogram, psfImageConfig.slots.apFlux = "base_CircularApertureFlux_3_0", but that doesn't correspond to the line in measurePsfTask.

That example fails when trying to create the source table, but it fails on a different CircularApertureFlux, when run with a stack on master:

 $./measurePsfTask.py  Using matplotlib backend: Qt5Agg Traceback (most recent call last):  File "./measurePsfTask.py", line 136, in   run(display=args.ds9)  File "./measurePsfTask.py", line 95, in run  tab = afwTable.SourceTable.make(schema) lsst.pex.exceptions.wrappers.NotFoundError:   File "src/table/Schema.cc", line 225, in lsst::afw::table::SchemaItem lsst::afw::table::detail::SchemaImpl::find(const string&) const [with T = double; std::__cxx11::string = std::__cxx11::basic_string]  Field or subfield withname 'base_CircularApertureFlux_12_0_flux' not found with type 'D'. {0} lsst::pex::exceptions::NotFoundError: 'Field or subfield withname 'base_CircularApertureFlux_12_0_flux' not found with type 'D'.'  Given that the example doesn't work as-is, I'm tempted to either remove the example, or not touch it. Suggestions? Show John Parejko added a comment - secondMomentSS does have this line in _PsfShapeHistogram , psfImageConfig.slots.apFlux = "base_CircularApertureFlux_3_0" , but that doesn't correspond to the line in measurePsfTask. That example fails when trying to create the source table, but it fails on a different CircularApertureFlux, when run with a stack on master:$ ./measurePsfTask.py Using matplotlib backend: Qt5Agg Traceback (most recent call last): File "./measurePsfTask.py", line 136, in <module> run(display=args.ds9) File "./measurePsfTask.py", line 95, in run tab = afwTable.SourceTable.make(schema) lsst.pex.exceptions.wrappers.NotFoundError: File "src/table/Schema.cc", line 225, in lsst::afw::table::SchemaItem<T> lsst::afw::table::detail::SchemaImpl::find(const string&) const [with T = double; std::__cxx11::string = std::__cxx11::basic_string<char>] Field or subfield withname 'base_CircularApertureFlux_12_0_flux' not found with type 'D'. {0} lsst::pex::exceptions::NotFoundError: 'Field or subfield withname 'base_CircularApertureFlux_12_0_flux' not found with type 'D'.' Given that the example doesn't work as-is, I'm tempted to either remove the example, or not touch it. Suggestions?
Hide
John Parejko added a comment -

Filed DM-14249 to deal with the broken example.

Show
John Parejko added a comment - Filed DM-14249 to deal with the broken example.
Hide
John Parejko added a comment -

Thank you for the quick review.

Merged and done.

Show
John Parejko added a comment - Thank you for the quick review. Merged and done.

## People

• Assignee:
John Parejko
Reporter:
John Parejko
Reviewers:
Watchers:
Chris Morrison, John Parejko, John Swinbank, Yusra AlSayyad