Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14237

Change DecamIngestTask --filetype default from instcal to raw

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None

      Description

      As discussed in RFC-478, DecamIngestTask requires a --filetype argument to ingest raw data, something its supertask IngestTask does by default. Change the default of --filetype to raw so that DecamIngestTask behaves like IngestTask when given the same arguments.

      This work includes updating obs_decam documentation and updating any calls to DecamIngestTask that assume the old default.

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. DM-13849 Convert all ap_verify test data to obs_test

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-478 Let DecamIngestTask ingest raws by default

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Hi Hsin-Fang Chiang, would you be willing to review the changes to obs_decam to make sure I haven't broken or omitted anything?

            Simon Krughoff, after discovering that validate_drp's scripts are exercised by lsst_ci, I went ahead and modified them. Can you review those changes?

            Show
            krzys Krzysztof Findeisen added a comment - Hi Hsin-Fang Chiang , would you be willing to review the changes to obs_decam to make sure I haven't broken or omitted anything? Simon Krughoff , after discovering that validate_drp 's scripts are exercised by lsst_ci , I went ahead and modified them. Can you review those changes?
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            obs_decam looks good to me.

            I didn't know how to test this besides actually running the scenarios of ingesting by hand; it's great to hear that validate_drp is doing the tests in lsst_ci!

            Removed my name from the reviewer list and Simon can mark this reviewed when he's done.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - obs_decam looks good to me. I didn't know how to test this besides actually running the scenarios of ingesting by hand; it's great to hear that validate_drp is doing the tests in lsst_ci! Removed my name from the reviewer list and Simon can mark this reviewed when he's done.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Looks good to me.

            Show
            krughoff Simon Krughoff added a comment - Looks good to me.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Thanks for the quick reviews!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for the quick reviews!

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Simon Krughoff
              Watchers:
              Hsin-Fang Chiang, Krzysztof Findeisen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.