Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14262

Cleanup fallout from removing interpolated from badFlags list

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None

      Description

      DM-13493 removed interpolated_flag from the badFlags list in BaseSourceSelectorTask, but did not remove it from BaseStarSelectorTask. Removing it from starSelector results in the dm_stack_demo failing because the sources change. In order to finish unifying the starSelectors, we have do decide how to properly manage this change.

      One option would be to append interpolated_flag to badFlags in objectSizeSS and any other "only select PSF sources" starSelectors (i.e. "true" starSelectors, instead of sourceSelectors). That at least would keep the status quo.

        Attachments

          Issue Links

          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-645 Deprecate obs_sdss and lsst_stack_demo

          • Implemented

          Bug - A problem which impairs or prevents the functions of the product. DM-13493 BaseSourceSelectorConfig should not filter on "interpolated"

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Lauren MacArthur found the relevant discussion:

            https://lsstc.slack.com/archives/C2JPL2DGD/p1525206128000555

            It appears that the best current behavior is for PSFy starSelectors to incorporate interpolated in the badFlags list, but generic sourceSelectors to not.

            Show
            Parejkoj John Parejko added a comment - Lauren MacArthur found the relevant discussion: https://lsstc.slack.com/archives/C2JPL2DGD/p1525206128000555 It appears that the best current behavior is for PSFy starSelectors to incorporate interpolated in the badFlags list, but generic sourceSelectors to not.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Removed mention of the stack demo from the summary of this ticket, since it's going away (per RFC-645). Not checked to see how much other fallout there might be.

            Show
            swinbank John Swinbank added a comment - Removed mention of the stack demo from the summary of this ticket, since it's going away (per RFC-645 ). Not checked to see how much other fallout there might be.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.