Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14273

Add ap_verify to lsst_distrib

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      AP F18-4, AP F18-5
    • Team:
      Alert Production

      Description

      Add ap_verify to lsst_distrib, and add ap_pipe and its dependencies to lsst_apps. This includes:

      1. Moving the packages to the lsst organization, and assigning admin privileges as described in the developer guide. [Note: this step cannot have an associated pull request].
      2. Confirming that packages follow Stack conventions (e.g., directory structure).
      3. Registering any missing packages with repos.yaml.
      4. Double-checking that any data package that is an optional dependency of a non-data package is also in manifest.remap.
      5. Adding ap_verify and ap_pipe to their respective top-level packages' table files.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15806 Switch ap_verify to requesting l1dbproto

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15983 Create a Jenkins job for ap_verify

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15872 Incorporate AP documentation into pipelines.lsst.io

          • Done
          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15775 Migrate parts of l1dbproto to the stack

          • Done
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-13849 Convert all ap_verify test data to obs_test

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12315 Generalize ap_pipe to non-HiTS data

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14557 Add package docs to datasets

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-521 Add ap_verify and its dependencies to the Stack

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Blocked by addition of l1dbproto to lsst_distrib, but I can't find a ticket for that and probably shouldn't be the one to create it.

            Show
            krzys Krzysztof Findeisen added a comment - Blocked by addition of l1dbproto to lsst_distrib , but I can't find a ticket for that and probably shouldn't be the one to create it.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            That shouldn't block this issue. Chris Morrison [X] may correct me, but my understanding is that ap_association (and hence everything else) should be runnable without l1dbproto. It make take some imaginative use of (or non-use-of) `setupOptional` commands to make things work, though.

            That said, it is important that we be able to CI the work that is using l1dbproto. Fritz Mueller might wish to comment on what he sees as the future for this package. We shouldn't wait for that to resolve this issue, though.

            Show
            swinbank John Swinbank added a comment - That shouldn't block this issue. Chris Morrison [X] may correct me, but my understanding is that ap_association (and hence everything else) should be runnable without l1dbproto. It make take some imaginative use of (or non-use-of) `setupOptional` commands to make things work, though. That said, it is important that we be able to CI the work that is using l1dbproto. Fritz Mueller might wish to comment on what he sees as the future for this package. We shouldn't wait for that to resolve this issue, though.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Per our August 30 meeting, we will try to include l1dbproto in lsst_apps (with the developers' permission) instead of making it an optional dependency of ap_association.

            Show
            krzys Krzysztof Findeisen added a comment - Per our August 30 meeting , we will try to include l1dbproto in lsst_apps (with the developers' permission) instead of making it an optional dependency of ap_association .
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            All steps done except #5, which requires resolution of DM-15775 first.

            Show
            krzys Krzysztof Findeisen added a comment - All steps done except #5, which requires resolution of DM-15775 first.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Hi Tim Jenness, as part of this ticket I had to do a fair bit of cleanup to get the ap_* packages to comply with Stack standards. Can you take a look and confirm that everything is now done correctly? Thanks!

            Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28724/

            Show
            krzys Krzysztof Findeisen added a comment - - edited Hi Tim Jenness , as part of this ticket I had to do a fair bit of cleanup to get the ap_* packages to comply with Stack standards. Can you take a look and confirm that everything is now done correctly? Thanks! Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28724/
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks okay. I've got some minor comments on left over python2 compatibility and a table file with cruft in. I found naming the PRs after the Jira ticket name to be extremely confusing given that the PRs 4 out of 5 were not related to ap_verify being added to lsst_distrib.

            Show
            tjenness Tim Jenness added a comment - Looks okay. I've got some minor comments on left over python2 compatibility and a table file with cruft in. I found naming the PRs after the Jira ticket name to be extremely confusing given that the PRs 4 out of 5 were not related to ap_verify being added to lsst_distrib.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Thanks for the feedback!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for the feedback!

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.