Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_association, ap_pipe, ap_verify
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:AP F18-4, AP F18-5
-
Team:Alert Production
Description
Add ap_verify to lsst_distrib, and add ap_pipe and its dependencies to lsst_apps. This includes:
- Moving the packages to the lsst organization, and assigning admin privileges as described in the developer guide. [Note: this step cannot have an associated pull request].
- Confirming that packages follow Stack conventions (e.g., directory structure).
- Registering any missing packages with repos.yaml.
- Double-checking that any data package that is an optional dependency of a non-data package is also in manifest.remap.
- Adding ap_verify and ap_pipe to their respective top-level packages' table files.
Attachments
Issue Links
- blocks
-
- Done
-
- Done
-
- Done
- has to be done after
-
- Done
- is blocked by
-
DM-13849 Convert all ap_verify test data to obs_test
- Done
-
- Done
-
- Done
- is triggered by
-
- Implemented
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Risk Score | 0 |
| Rank | Ranked higher |
| Description | This is a blocker for all the work we need to do to get ap_verify into lsst_distrib. |
(Also its dependencies ap_association & ap_pipe).
This is a blocker for all the work we need to do to get ap_verify into lsst_distrib. |
| Component/s | ap_association [ 14501 ] | |
| Component/s | ap_pipe [ 14281 ] |
Krzysztof Findeisen
made changes -
Krzysztof Findeisen
made changes -
That shouldn't block this issue. Chris Morrison [X] may correct me, but my understanding is that ap_association (and hence everything else) should be runnable without l1dbproto. It make take some imaginative use of (or non-use-of) `setupOptional` commands to make things work, though.
That said, it is important that we be able to CI the work that is using l1dbproto. Fritz Mueller might wish to comment on what he sees as the future for this package. We shouldn't wait for that to resolve this issue, though.
| Sprint | AP F18-3 [ 748 ] | |
| Story Points | 4 |
| Sprint | AP F18-3 [ 748 ] | AP F18-4 [ 749 ] |
| Assignee | John Swinbank [ swinbank ] | Krzysztof Findeisen [ krzys ] |
Per our August 30 meeting, we will try to include l1dbproto in lsst_apps (with the developers' permission) instead of making it an optional dependency of ap_association.
Krzysztof Findeisen
added a comment - Per our August 30 meeting , we will try to include l1dbproto in lsst_apps (with the developers' permission) instead of making it an optional dependency of ap_association . Krzysztof Findeisen
made changes -
| Priority | Undefined [ 10000 ] | Major [ 3 ] |
Krzysztof Findeisen
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Krzysztof Findeisen
made changes -
| Description |
(Also its dependencies ap_association & ap_pipe).
This is a blocker for all the work we need to do to get ap_verify into lsst_distrib. |
Add {{ap_verify}} to {{lsst_distrib}}, and add {{ap_pipe}} and its dependencies to {{lsst_apps}}. This includes:
# Moving the packages to the {{lsst}} organization, and assigning admin privileges as described in the [developer guide|https://developer.lsst.io/stack/adding-a-new-package.html]. [Note: this step cannot have an associated pull request]. # Confirming that packages follow Stack conventions (e.g., directory structure). # Registering any missing packages with {{repos.yaml}}. # Double-checking that any data package that is an optional dependency of a non-data package is also in {{manifest.remap}}. # Adding {{ap_verify}} and {{ap_pipe}} to their respective top-level packages' table files. |
Krzysztof Findeisen
made changes -
Krzysztof Findeisen
made changes -
All steps done except #5, which requires resolution of DM-15775 first.
Krzysztof Findeisen
added a comment - All steps done except #5, which requires resolution of DM-15775 first. Krzysztof Findeisen
made changes -
Hi Tim Jenness, as part of this ticket I had to do a fair bit of cleanup to get the ap_* packages to comply with Stack standards. Can you take a look and confirm that everything is now done correctly? Thanks!
Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28724/
Krzysztof Findeisen
added a comment - - edited Hi Tim Jenness , as part of this ticket I had to do a fair bit of cleanup to get the ap_* packages to comply with Stack standards. Can you take a look and confirm that everything is now done correctly? Thanks!
Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28724/ Krzysztof Findeisen
made changes -
| Reviewers | Tim Jenness [ tjenness ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Sprint | AP F18-4 [ 749 ] | AP F18-4, AP F18-5 [ 749, 750 ] |
Looks okay. I've got some minor comments on left over python2 compatibility and a table file with cruft in. I found naming the PRs after the Jira ticket name to be extremely confusing given that the PRs 4 out of 5 were not related to ap_verify being added to lsst_distrib.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Thanks for the feedback!
Krzysztof Findeisen
added a comment - Thanks for the feedback! Krzysztof Findeisen
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Krzysztof Findeisen
made changes -
Blocked by addition of l1dbproto to lsst_distrib, but I can't find a ticket for that and probably shouldn't be the one to create it.