Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14275

The distortion in test_wcsUtils.py testDistortion is unreasonable

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      The distortion model used in test_wcsUtils.py's testDistortion method is not reasonable (the distortion is far too much to be reasonable).

      I noticed this when that test failed testing a fix to starlink_ast on DM-14162

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-14162 Iterative inverse of radial transform not acceptably accurate

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I also increased the number of iterations for the iterative inverse of distortion models produced by makeRadialTransform. This improves the inverse in some cases, though normally it's not required. See also DM-14162.

            Show
            rowen Russell Owen added a comment - I also increased the number of iterations for the iterative inverse of distortion models produced by makeRadialTransform. This improves the inverse in some cases, though normally it's not required. See also DM-14162 .
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Two small changes to afw.

            • In in test_wcsUtils.py make the distortion model reasonable and correct the direction of the pixels to tangent plane model.
            • Increase the number of iterations to 30 for the transform returned by makeRadialTransform. In all my testing of DM-14162 30 has always sufficed, and that change was needed for the saner distortion model in test_wcsUtils.py to pass without using the DM-14162 branch of AST. Also I have found one instance of a model where more than 20 iterations (the old value) is required even with the DM-14162 branch of AST.
            Show
            rowen Russell Owen added a comment - Two small changes to afw. In in test_wcsUtils.py make the distortion model reasonable and correct the direction of the pixels to tangent plane model. Increase the number of iterations to 30 for the transform returned by makeRadialTransform. In all my testing of DM-14162 30 has always sufficed, and that change was needed for the saner distortion model in test_wcsUtils.py to pass without using the DM-14162 branch of AST. Also I have found one instance of a model where more than 20 iterations (the old value) is required even with the DM-14162 branch of AST.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            See the PR for one question, otherwise this is good.

            Show
            Parejkoj John Parejko added a comment - See the PR for one question, otherwise this is good.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Question answered (and in such a way that I felt confident merging the code and marking this done)

            Show
            rowen Russell Owen added a comment - - edited Question answered (and in such a way that I felt confident merging the code and marking this done)

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.