Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14290

Do not raise generic Exceptions

    XMLWordPrintable

    Details

    • Story Points:
      2

      Description

      We have several bits of code that raise either Exception or lsst.pex.exceptions.Exception/pexExcept.Exception. We should replace all of those with an appropriately specific exception. The generic Exception should almost never be raised (or caught, but that's a different issue).

        Attachments

          Issue Links

          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-14310 Fix catching of generic Exceptions

          • To Do

          Bug - A problem which impairs or prevents the functions of the product. DM-10402 Never use assertRaises(Exception), always test a specific exception

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            9 older comments
            Hide
            Permalink
            sophiereed Sophie Reed added a comment -

            I've made PRs for the branches but they are taking a while to show up. Thanks for looking at this.

            Show
            sophiereed Sophie Reed added a comment - I've made PRs for the branches but they are taking a while to show up. Thanks for looking at this.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good. My main quibble is whether we should be changing ctrl_provenance at all. Please resolve the question on fitType exception posed by Merlin Fisher-Levine. The documentation should reflect reality.

            Show
            tjenness Tim Jenness added a comment - Looks good. My main quibble is whether we should be changing ctrl_provenance at all. Please resolve the question on fitType exception posed by Merlin Fisher-Levine . The documentation should reflect reality.
            Hide
            Permalink
            dtaranu Dan Taranu added a comment - - edited

            Tim Jenness: John Swinbank kindly marked ctrl_provenance as deprecated (as per https://lsstc.slack.com/archives/C2JPL2DGD/p1594415808139000?thread_ts=1594415808.139000) so I think that's settled - there's still an active branch but it should be clear that nobody needs to look at it ever again.

            Show
            dtaranu Dan Taranu added a comment - - edited Tim Jenness : John Swinbank kindly marked ctrl_provenance as deprecated (as per https://lsstc.slack.com/archives/C2JPL2DGD/p1594415808139000?thread_ts=1594415808.139000 ) so I think that's settled - there's still an active branch but it should be clear that nobody needs to look at it ever again.
            Hide
            Permalink
            dtaranu Dan Taranu added a comment -

            Tim Jenness I believe Merlin Fisher-Levine's objection was resolved - the doc change does reflect reality. Having said that, is it really advisable to document downstream behaviour? It seems like it would become impossible to maintain.

            Show
            dtaranu Dan Taranu added a comment - Tim Jenness I believe Merlin Fisher-Levine 's objection was resolved - the doc change does reflect reality. Having said that, is it really advisable to document downstream behaviour? It seems like it would become impossible to maintain.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Sorry. I hadn't realized that you were waiting for my okay. Fine with me.

            Show
            tjenness Tim Jenness added a comment - Sorry. I hadn't realized that you were waiting for my okay. Fine with me.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Tim Jenness
              Watchers:
              Dan Taranu, John Parejko, Kian-Tat Lim, Morgan Schmitz, Sophie Reed, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: