Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14295

Write unittests for PerTractCcdDataIdContainer and unify it with other versions

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Team:
      Alert Production

      Description

      jointcal's PerTractCcdDataIdContainer doesn't have any tests, so its exact behavior given various inputs is not entirely clear. We should add some tests for it using some fake visit/tract combinations: list of visits all in a tract; list of tracts with no visits; list of visits in different tracts, would be a good start.

      As part of this, we should explore merging the existing versions of this code into one, so that the code and tests only live in one package (possibly pipe_base? Or maybe daf_butler?). Possibilities to include in this unification include:

      • jointcal.dataIds.PerTractCcdDataIdContainer
      • meas.base.forcedPhotCcd.PerTractCcdDataIdContainer
      • coadd.utils.CoaddDataIdContainer
      • pipe.tasks.assembleCoadd.AssembleCoaddDataIdContainer

      This should wait for Gen3 Butler, as that will eliminate the "Reading WCS to determine tracts" part of the code, since making up fake WCSs would make writing the test much harder.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            I believe we can mark this "won't fix" since it won't be necessary for gen3? Similarly for the other three similar containers listed above.

            Show
            Parejkoj John Parejko added a comment - I believe we can mark this "won't fix" since it won't be necessary for gen3? Similarly for the other three similar containers listed above.
            Hide
            jbosch Jim Bosch added a comment -

            I believe we can mark this "won't fix" since it won't be necessary for gen3? Similarly for the other three similar containers listed above.

            Correct.  Doing that.

            Show
            jbosch Jim Bosch added a comment - I believe we can mark this "won't fix" since it won't be necessary for gen3? Similarly for the other three similar containers listed above. Correct.  Doing that.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, John Parejko, John Swinbank, Nicolas Chotard, Paul Price, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.