Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14305

Upgrade Eigen to 3.3.4

    XMLWordPrintable

    Details

      Description

      Implementation of RFC-479.

      For now, this is exploratory work, to see just how bad the changes to ndarray are going to be.

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-18896 Compute determinant of matrix before factorization

          • To Do
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15023 meas_modelfit is not compatible with Eigen 3.3.4

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14725 Eliminate explicit use of ndarray::EigenView in C++ code

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14728 Add asEigenArray/Matrix returning Eigen::Map

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14781 Upgrade Eigen to 3.2.10

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14834 Use pybind11's native Eigen wrapping instead of ndarray EigenView

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-479 Upgrade Eigen to 3.3.4

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Updating the tarball and removing the patch results in a failure to build on my MacOS Sierra system:

            Run Build Command:"/usr/bin/make" "cmTC_720cf/fast"
            		 
            /Applications/Xcode.app/Contents/Developer/usr/bin/make -f CMakeFiles/cmTC_720cf.dir/build.make CMakeFiles/cmTC_720cf.dir/build
            		 
            Building Fortran object CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o
            		 
            CMAKE_Fortran_COMPILER-NOTFOUND    -c /Users/rowen/UW/LSST/lsstsw3/build/eigen/build/CMakeFiles/CMakeTmp/testFortranCompiler.f -o CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o
            		 
            make[1]: CMAKE_Fortran_COMPILER-NOTFOUND: No such file or directory
            		 
            make[1]: *** [CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o] Error 1
            		 
            make: *** [cmTC_720cf/fast] Error 2

            Show
            rowen Russell Owen added a comment - Updating the tarball and removing the patch results in a failure to build on my MacOS Sierra system: Run Build Command:"/usr/bin/make" "cmTC_720cf/fast" /Applications/Xcode.app/Contents/Developer/usr/bin/make -f CMakeFiles/cmTC_720cf.dir/build.make CMakeFiles/cmTC_720cf.dir/build Building Fortran object CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o CMAKE_Fortran_COMPILER-NOTFOUND -c /Users/rowen/UW/LSST/lsstsw3/build/eigen/build/CMakeFiles/CMakeTmp/testFortranCompiler.f -o CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o make[1]: CMAKE_Fortran_COMPILER-NOTFOUND: No such file or directory make[1]: *** [CMakeFiles/cmTC_720cf.dir/testFortranCompiler.f.o] Error 1 make: *** [cmTC_720cf/fast] Error 2
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            John Parejko found two patches used by homebrew. When applied they fix the mac build. With those patches John confirms that it still builds on his linux box.

            Show
            rowen Russell Owen added a comment - - edited John Parejko found two patches used by homebrew. When applied they fix the mac build. With those patches John confirms that it still builds on his linux box.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Everything now builds, but some flux values in lsst_dm_stack_demo have changed slightly, so that will also have to be updated.

            Show
            rowen Russell Owen added a comment - Everything now builds, but some flux values in lsst_dm_stack_demo have changed slightly, so that will also have to be updated.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Only comment is that it looks like you didn't git rm the old eigen.

            Show
            Parejkoj John Parejko added a comment - Only comment is that it looks like you didn't git rm the old eigen.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Thanks. I'll run Jenkins again just to be sure that the old version was not messing anything up. Based on the need to modify meas_modelFit (DM-15023) and lsst_dm_stack_demo I know that Eigen had changed, but it's best to be sure there was no interference.

            Show
            rowen Russell Owen added a comment - - edited Thanks. I'll run Jenkins again just to be sure that the old version was not messing anything up. Based on the need to modify meas_modelFit ( DM-15023 ) and lsst_dm_stack_demo I know that Eigen had changed, but it's best to be sure there was no interference.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              John Parejko
              Watchers:
              Jim Bosch, John Parejko, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.